$result = mysql_query("UPDATE categories
SET cd_title='$docuTitle' , cd_link='$linkTitle'
WHERE c_name='$catID'");
What is wrong with this update query?
-
The query looks fine. Please be more specific.Gumbo– Gumbo2009-07-16 14:02:48 +00:00Commented Jul 16, 2009 at 14:02
-
2What's the error given? mysql_error () should output it.Meep3D– Meep3D2009-07-16 14:04:03 +00:00Commented Jul 16, 2009 at 14:04
-
Are your variables properly escaped?niteria– niteria2009-07-16 14:06:02 +00:00Commented Jul 16, 2009 at 14:06
Add a comment
|
3 Answers
There is probably something wrong with the data in your variables — but we can't see what they contain.
You should be using parameterized queries, which would deal with any odd characters in your data that might mess up the statement.
See How can I prevent SQL injection in PHP? and When are the most recommended times to use mysql_real_escape_string()
Comments
I would change the query to this, to avoid errors if input contains apostrophes:
$result = mysql_query(
"UPDATE categories SET
cd_title='" . mysql_real_escape_string($docuTitle) . "',
cd_link='" . mysql_real_escape_string($linkTitle) . "'
WHERE
c_name='" . mysql_real_escape_string($catID) . "'");
Comments
If your data is sanitized, remove the single quotes from around the php variables.
