PHP - If statement not working correctly in foreach loop

Question

Hi I have this code here:

public function length($args) {
    if (isset($this->length)) {
        foreach ($this->length as $k => $v) {
            if (strlen($args[$k])>=$v[0] && strlen($args[$k])<$v[1]) {
                return true;
            } else {
                array_push($this->form_errors, $v[2]);
                return false;
            }
        }
    } else { 
        return true;
    }
}

I'm not sure why but its not working as expected. The foreach loop only loops through one of the $args[$k] even though there are 2 of them. Anyone have any idea whats going on? I'm writing this question in a hurry so if I need to explain anything else, please let me know.

Thanks!

put return value into variable and return it at the end of function. — Wh1T3h4Ck5
– Wh1T3h4Ck5, Commented Aug 26, 2012 at 2:43

Marc B · Accepted Answer · 2012-08-26 02:39:24Z

9

Your two return statements in both sides of the if() clause terminate the function on the first iteration of the loop. Either the strlen stuff is true and you return true, or they're false and you return false. regardless, the loop ends.

If you simply want to jump to the next iteration, then use continue instead, which'd allow the foreach to proceed.

answered Aug 26, 2012 at 2:39

Marc B

362k44 gold badges433 silver badges508 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Barmar Over a year ago

But there's no need for a continue, because there's nothing else in the loop.

Collectives™ on Stack Overflow

PHP - If statement not working correctly in foreach loop

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related