Should I call str_replace() with an array of search strings or call str_replace() over and over for each search string? [closed]

Question

Closed. This question is opinion-based. It is not currently accepting answers.

Want to improve this question? Because this question may lead to opinionated discussion, debate, and answers, it has been closed. You may edit the question if you feel you can improve it so that it requires answers that include facts and citations or a detailed explanation of the proposed solution. If edited, the question will be reviewed and might be reopened.

Closed last year.

Improve this question

When converting new line characters to HTML break (<br>)

What is Cleaner to use?

str_replace(array("\r\n", "[br]", "\r"), '<br>', $Content);

OR

str_replace("\r\n", '<br>', $Content);
str_replace("[br]", '<br>', $Content);
str_replace("\r", '<br>', $Content);

I've been using the first method, but a friend of mine said that the way I currently use is more sloppy in terms of processing.

I'm using the formatting in a function; so

function Formatting ($Content)
{
 $Content = str_replace(array("\r\n", "[br]", "\r"), '<br>', $Content);
 return $Content;
}

The second way is probably faster, but only by some microseconds even if that. Use whichever approach you will find easier to understand for when you (or your acquaintances) maintain the code. — FThompson
– FThompson, Commented Nov 28, 2012 at 3:07
what about "\n" ? the user notes on the nl2br() have some fine examples of covering all the possibilities. — user557846
– user557846, Commented Nov 28, 2012 at 3:08
@Vulcan So in terms of processing, we're talking about time which isn't any substantial amount — Daryl Gill
– Daryl Gill, Commented Nov 28, 2012 at 3:10
@Dagon I quickly typed this up to give the people viewing the idea of what I am doing — Daryl Gill
– Daryl Gill, Commented Nov 28, 2012 at 3:11
type slower, we only know what you type, don't make people helping you for free have to guess — user557846
– user557846, Commented Nov 28, 2012 at 3:14

user557846 · Accepted Answer · 2012-11-28 03:12:25Z

I would tweak this one myself (from the user notes in the manual page http://php.net/manual/en/function.nl2br.php:

<?php
/**
 * Converts newlines and break tags to an
 * arbitrary string selected by the user,
 * defaults to PHP_EOL.
 *
 * In the case where a break tag is followed by
 * any amount of whitespace, including \r and \n,
 * the tag and the whitespace will be converted
 * to a single instance of the line break argument.
 *
 * @author Matthew Kastor
 * @param string $string
 *   string in which newlines and break tags will be replaced
 * @param string $line_break
 *   replacement string for newlines and break tags
 * @return string
 *   Returns the original string with newlines and break tags
 *   converted
 */
function convert_line_breaks($string, $line_break=PHP_EOL) {
    $patterns = array(   
                        "/(<br>|<br \/>|<br\/>)\s*/i",
                        "/(\r\n|\r|\n)/"
    );
    $replacements = array(   
                            PHP_EOL,
                            $line_break
    );
    $string = preg_replace($patterns, $replacements, $string);
    return $string;
}
?>

Daryl Gill · Accepted Answer · 2012-11-28 03:13:44Z

0

In Response to Dagons comment, his suggestion worked perfectly; no need to create a new function to do this task by using nl2br()

http://php.net/manual/en/function.nl2br.php

answered Nov 28, 2012 at 3:13

Daryl Gill

5,52511 gold badges41 silver badges71 bronze badges

1 Comment

user557846 Over a year ago

well you do to replace [br]

Collectives™ on Stack Overflow

Should I call str_replace() with an array of search strings or call str_replace() over and over for each search string? [closed]

2 Answers 2

Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Related