Add new rows to a DataTable programmatically C#

Question

I have a DataTable which I fill from a database and the in code behind I am trying to add 3 more rows after each row. Below is the code. But at the 6th line I get

Exception of type 'System.OutOfMemoryException' was thrown.

  for (int i = 0; i < AlldaysList.Rows.Count; i++)
    {
        DataRow row;
        row = AlldaysList.NewRow();
        DataRow row1;
        row1 = AlldaysList.NewRow();
        DataRow row2;
        row2 = AlldaysList.NewRow();

        // Then add the new row to the collection.
        row["scenarionid"] = DBNull.Value;
        row["description"] = "";
        row1["scenarionid"] = DBNull.Value;
        row1["description"] = "";
        row2["scenarionid"] = DBNull.Value;
        row2["description"] = "";
        AlldaysList.Rows.InsertAt(row, i + 1);
        AlldaysList.Rows.InsertAt(row1, i + 2);
        AlldaysList.Rows.InsertAt(row2, i + 3);
        i++;
    }

for (int i = 0; i < AlldaysList.Rows.Count; i++).... modify this to for (int i = 0; i < AlldaysList.Rows.Count + 2; i++).. — Uthistran Selvaraj
– Uthistran Selvaraj, Commented Jan 28, 2013 at 9:57

Raghavan · Accepted Answer · 2013-01-28 10:03:25Z

4

//This could be the problem
i < AlldaysList.Rows.Count

i think u should have a variable called int rowCount = AlldaysList.Rows.Count; before the loop..

the loop should be  for (int i = 0; i < rowCount; i++)

The reason why i say this is because if u add 3 rows inside the loop ur AlldaysList.Rows.Count is changing by +3 and u r targeting a dynamic variable instead of a static one and so it goes into the loop again and causes an exception..

answered Jan 28, 2013 at 10:03

Raghavan

6373 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JLRishe · Accepted Answer · 2013-01-28 10:05:50Z

1

I think you should do something like this:

int origRowCount = AlldaysList.Rows.Count;
for (int i = 0; i < origRowCount; i++)
{
    for (int j = 1; j <= 3; j++)
    {
        AlldaysList.Rows.InsertAt(MakeNewAlldaysRow(AlldaysList), i * 4 + j);
    }
}

// ....
// (separate method)
static DataRow MakeNewAlldaysRow(DataTable table)
{
    DataRow row = table.NewRow();
    row["scenarionid"] = DBNull.Value;
    row["description"] = "";

    return row;
}

Since the list of rows is going to be increasing, you need to make a note of the row count before you start adding rows. Also, the insert locations are going to be increasing by 4, hence i * 4 + j.

answered Jan 28, 2013 at 10:05

JLRishe

102k19 gold badges138 silver badges171 bronze badges

Comments

SUHAIL AG · Accepted Answer · 2014-10-01 07:50:34Z

0

Generalised version of your code, you can add any number of rows by just changing the value of variable RowsToAdd. You dn't need crate three DataRow variable(row,row1,row2)...

int RowsToAdd=3
int rowCount = AlldaysList.Rows.Count;
for (int i = 0; i < rowCount; i++)
{
   for (int j = 0; j < RowsToAdd; j++)
   {
     DataRow dr = AlldaysList.NewRow();
     dr["scenarionid"] = DBNull.Value;
     dr["description"] = "";

     AlldaysList.Rows.Add(dr);
   }
}

answered Oct 1, 2014 at 7:50

SUHAIL AG

1951 silver badge8 bronze badges

Collectives™ on Stack Overflow

Add new rows to a DataTable programmatically C#

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related