update syntax error in the code any help on this

Question

In my update query i am getting an update syntax error in the following code....

Private Sub btnSave_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnSave.Click
    Dim strup As String
    Try
        strup = "update MCA set urno=" & CInt(txtUrn.Text) & ",sname='" & txtName.Text & "',fname='" & txtFname.Text & "',CAddress='" & txtCAdd.Text & "',PAddress='" & txtPAdd.Text & "',EmailID='" & txtEid.Text & "',cmbdate=" & CInt(cmbDate.Text) & ",cmbmonth='" & cmbMonth.Text & "',cmbyear=" & CInt(cmbYear.Text) & ",Gender='" & cmbGender.Text & "',Mobile" & CLng(txtMno.Text) & ",10PSSC=" & CInt(txt10Per.Text) & ",12PHSC=" & CInt(txt12Per.Text) & ",10YSSC='" & cmb10YofPass.Text & "',12YHSC='" & cmb12YofPass.Text & "',Course='" & cmbNameofGCourse.Text & "',gper=" & CInt(txtGPer.Text) & " WHERE urno =" & (txtUrn.Text) & ";"
        Dim command As New OleDb.OleDbCommand(strup, con)
        command.ExecuteNonQuery()
        con.Open()
        con.Close()
        MsgBox("Record Updated")

    Catch ex As Exception
        MsgBox(ex.ToString())
    End Try
End Sub

Andrey Gordeev · Accepted Answer · 2013-02-21 04:22:40Z

1

Try:

strup = "update MCA set urno=" & CInt(txtUrn.Text) & ",sname='" & txtName.Text & "',fname='" & txtFname.Text & "',CAddress='" & txtCAdd.Text & "',PAddress='" & txtPAdd.Text & "',EmailID='" & txtEid.Text & "',cmbdate=" & CInt(cmbDate.Text) & ",cmbmonth='" & cmbMonth.Text & "',cmbyear=" & CInt(cmbYear.Text) & ",Gender='" & cmbGender.Text & "',Mobile=" & CLng(txtMno.Text) & ",10PSSC=" & CInt(txt10Per.Text) & ",12PHSC=" & CInt(txt12Per.Text) & ",10YSSC='" & cmb10YofPass.Text & "',12YHSC='" & cmb12YofPass.Text & "',Course='" & cmbNameofGCourse.Text & "',gper=" & CInt(txtGPer.Text) & " WHERE urno =" & (txtUrn.Text) & ";"

You have "',Mobile" & CLng(txtMno.Text) instead of "',Mobile=" & CLng(txtMno.Text)

answered Feb 21, 2013 at 4:22

Andrey Gordeev

32.7k16 gold badges143 silver badges169 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

CrashOverride Over a year ago

Thanks a lot it works but now it throws an exception that the connection state was not closed...?

Andrey Gordeev Over a year ago

@user1897472 put con.Open() before executing query

CrashOverride Over a year ago

tried that its still the same...? tried before command.executenonquery

Andrey Gordeev Over a year ago

@user1897472 Then remove con.Open(). It seems the connection is already open

CrashOverride Over a year ago

as usual you were right Andrey Thanks a lot mate.. Have a good day :)

Rahul Gokani · Accepted Answer · 2013-02-21 04:41:20Z

Same as above answer and additional that on the last value that is
WHERE urno =" & (txtUrn.Text) & ";" that a numeric or Text.

If it is numeric you should convert it or it is text then you should put it as
WHERE urno ='" & (txtUrn.Text) & "';"

This is how your Query will look like.

strup = "update MCA set urno=" & CInt(txtUrn.Text) & ",sname='" & txtName.Text & "',fname='" & txtFname.Text & "',CAddress='" & txtCAdd.Text & "',PAddress='" & txtPAdd.Text & "',EmailID='" & txtEid.Text & "',cmbdate=" & CInt(cmbDate.Text) & ",cmbmonth='" & cmbMonth.Text & "',cmbyear=" & CInt(cmbYear.Text) & ",Gender='" & cmbGender.Text & "',Mobile=" & CLng(txtMno.Text) & ",10PSSC=" & CInt(txt10Per.Text) & ",12PHSC=" & CInt(txt12Per.Text) & ",10YSSC='" & cmb10YofPass.Text & "',12YHSC='" & cmb12YofPass.Text & "',Course='" & cmbNameofGCourse.Text & "',gper=" & CInt(txtGPer.Text) & " WHERE urno ='" & (txtUrn.Text) & "';"

Collectives™ on Stack Overflow

update syntax error in the code any help on this

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related