PHP separate even and odd values from an array

Question

I'm using the below code to separate odd and even and store it in different variable. When there are only 2 value available then it works fine but when the number value increases then it doesn't. I want to make it dynamic so that n number of values can be separated and stored correctly.

Example: If the value of

$final_array = "PNL testing 1,10,PNL testing 2,35,";

It prints nicely:

$teams = "PNL testing 1, PNL testing 2";

$amount = "10, 35";

But when it increases from

$final_array = "PNL testing 1,10,PNL testing 2,35,";

to

$final_array = "PNL testing 1,10,PNL testing 2,35,Team 3,95,";

Then also it prints

$teams = "PNL testing 1, PNL testing 2";

$amount = "10, 35";

Please guide me through on where I am going wrong.

$res = array();
$result = preg_match_all("{([\w\s\d]+),(\d+)}", $final_array, $res);
$teams = join(', ', $res[1]); //will display teams
$amount = join(', ', $res[2]); //will display amount every team have
echo $teams . "<br />" . $amount;

Might find what your looking for here.. stackoverflow.com/questions/738168/filter-array-odd-even?rq=1 — Dom
– Dom, Commented Apr 26, 2013 at 8:33
The code you mentioned printed: PNL testing 1, PNL testing 2, Team 3 as $teams, and 10, 35, 95 as $amount, not what you said it printed. — Carlos Campderrós
– Carlos Campderrós, Commented Apr 26, 2013 at 8:37
So basically, you want to drop 1 team if the number of teams is odd? — nkkollaw
– nkkollaw, Commented Apr 26, 2013 at 8:42

sh03 · Accepted Answer · 2013-04-26 08:41:04Z

3

I think you can totally drop the REGEX in favor of good old explode/implode with some logic in it:

$teams = array();
$amount = array();

$a = explode(',', trim(trim($final_array), ','));
foreach ($a as $i => $v)
    if (($i % 2) == 0) $teams[] = trim($a);
    else $amount[] = trim($a);

$teams = implode(', ', $teams);
$amount = impode(', ', $amount);

In the above code $tms and $amn are temporary arrays. In the foreach we take the exploded values from the string and we store them in those two arrays sorting them by key (if it's even then it's a team otherwise it's an amount).

At the end we just implode the new values into your output variables $teams and $amount.

answered Apr 26, 2013 at 8:41

sh03

76.5k39 gold badges177 silver badges282 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Michal Trojanowski · Accepted Answer · 2013-04-26 08:53:16Z

0

It will much easier I think to use explode:

$result = explode(',', $final_array);

$teams = array();
$amount = array();

foreach ($result as $key => $value) {
    if ($key % 2 == 0) {
        $teams[] = $value;
    } else {
        $amount[] = $value;
    }
}

$teams  = implode(', ', $teams); //will display teams
$amount = implode(', ', $amount); //will display amount every team have
echo $teams."<br />".$amount;

edited Apr 26, 2013 at 8:53

answered Apr 26, 2013 at 8:41

Michal Trojanowski

12.6k4 gold badges30 silver badges47 bronze badges

3 Comments

sh03 Over a year ago

I think $key % 2 == 1 should be $key % 2 == 0.

nkkollaw Over a year ago

I would do that, too. Maybe start with rtrim($final_array, ',')..?

Michal Trojanowski Over a year ago

@Jueecy.new you're absolutely right. I had a moment of madness when I thought that 0 % 2 = 1. It scares me a bit now ;) @nbrogi - that is more of fine-tuning the code but of course is a valuable advice :)

Community · Accepted Answer · 2017-05-23 10:29:43Z

0

I would change this part of Michal Trojanowski for more efficiency

foreach ($result as $key => $value) {
    if ($key % 2 == 0) {
        $teams[] = $value;
    } else {
        $amount[] = $value;
    }
}

you see it has an extra condition we can remove it by like this

$length = count($result);//cache count result
for ($i = 0; $i < $length; $i += 2) {
    $teams[] = $result[$i];
}

for ($i = 1; $i < $length; $i += 2) {
    $amount[] = $result[$i];
}

Here the loop is running same but it just removes the the condition.

edited May 23, 2017 at 10:29

CommunityBot

11 silver badge

answered Feb 27, 2017 at 21:04

ARIF MAHMUD RANA

5,1963 gold badges39 silver badges58 bronze badges

Collectives™ on Stack Overflow

PHP separate even and odd values from an array

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related