Reading integers from text file in c# and writing them into array

Question

I'm trying to read the values of pixels from text file and generate an image file. But first I want to make sure that I can read all of the values in the file. I use this code, but the output misses some of the integers from the input file-the last ones. I don't know why! Can you help me? Here's the code:

namespace txtToImg
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
            TextWriter tw = new StreamWriter("D:\\out.txt");
            string fileContent = File.ReadAllText("D:\\in.txt");

            string[] integerStrings = fileContent.Split(new char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);

            int[] integers = new int[integerStrings.Length];
            //tw.Write(integerStrings.Length);

            for (int n = 0; n < integerStrings.Length; n++)
            {
                integers[n] = int.Parse(integerStrings[n]);

                tw.Write(integers[n]+" ");


            }
        }
    }
}

I notice the StreamWriter object doesn't appear to be getting closed. Not sure if that would make any difference, but its the only obvious thing I can see. — Andrew
– Andrew, Commented May 17, 2013 at 19:40
You sure that shouldn't be fileContent.Split(new char[] { ' ', '\n' }, ... ? — Matthew Watson
– Matthew Watson, Commented May 17, 2013 at 19:43
My integers are split by space, I don't need '\n' or ','. Thanks though! — fanciulla
– fanciulla, Commented May 17, 2013 at 19:46
Andrew, Thank you so much! I closed the StreamWriter object tw and it worked! I do not know why, but it works perfectly now! Thank you again! — fanciulla
– fanciulla, Commented May 17, 2013 at 19:48
@AnaZlateva The best way is to use using as in Bearcat's suggestion below. Then it will get closed automatically, even if an exception occurs. — Matthew Watson
– Matthew Watson, Commented May 17, 2013 at 19:50

Bearcat9425 · Accepted Answer · 2013-05-17 19:47:39Z

2

I agree with Andrew's comment your streamWriter object isn't getting closed so for one thing I would try this. I made the change below and attempted what you are doing and my output file contained all the entries.

 using (TextWriter tw = new StreamWriter(@"D:\out.txt"))
        {
            string fileContent = File.ReadAllText(@"D:\in.txt");

            string[] integerStrings = fileContent.Split(new char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);

            int[] integers = new int[integerStrings.Length];

            for (int n = 0; n < integerStrings.Length; n++)
            {
                integers[n] = int.Parse(integerStrings[n]);
                tw.Write(integers[n] + " ");
            }
        }

answered May 17, 2013 at 19:47

Bearcat9425

1,6081 gold badge12 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mehran Over a year ago

Ana if this answer has solved your problem , don't forget to choose it as your question's answer

Andrew · Accepted Answer · 2013-05-17 19:50:36Z

0

Right, I've just ran it and as I suspected you need the following after your loop:

tw.Close();

answered May 17, 2013 at 19:50

Andrew

2,3253 gold badges27 silver badges42 bronze badges

1 Comment

Bearcat9425 Over a year ago

Like Andrew suggested I would wrap your TextWriter in a using statement. It Implements IDiposable so after the closing brace tw is properly disposed, and your out file then is release and accessible to other processes.

Collectives™ on Stack Overflow

Reading integers from text file in c# and writing them into array

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related