Finding the maximum element of an array using recursion [closed]

Question

My Code is this will this find max number from array using recursion but it is not finding biggest Number

#include <stdio.h>

int maximum(int ar[], int n)
{

    if (n == 1) {
        return ar[0];

    } else {
        int max = maximum(ar, n-1);
        printf("Largest element : %d\n", max);
        return 5; // return ar[n-1] > max ? ar[n-1] : max;
    }
}

int main()
{
    int array[5] = {5, 23, 28, 7, 1};
    printf("Maximum element of the array is: %d", maximum(array, 5));
    return 0;
}

Where are you comparing numbers from the array? Hint: You're not. — NominSim
– NominSim, Commented May 29, 2013 at 14:01
Why you commented out return ar[n-1] > max ? ar[n-1] : max;? — johnchen902
– johnchen902, Commented May 29, 2013 at 14:01
You don't need recursion for this, just start out with the first element as your "max" and compare each element with the max. If the element you are comparing is bigger than the previous, then that becomes the max until the end. Use a for-loop starting at 1 and go to the end of the array. — user195488
– user195488, Commented May 29, 2013 at 14:03
There is no need for recursion here. The iterative solution is simpler and more efficient. — Raymond Chen
– Raymond Chen, Commented May 29, 2013 at 14:03
This program has bugs that we can't fix for you.. for instance, if you add another number to the array and increase n to 6, you read beyond the array. — user195488
– user195488, Commented May 29, 2013 at 14:19

bash.d · Accepted Answer · 2013-05-29 14:01:14Z

6

With this particular line

return 5; // return ar[n-1] > max ? ar[n-1] : max;

in

if (n == 1) {
        return ar[0];

    } else {
        int max = maximum(ar, n-1);
        printf("Largest element : %d\n", max);
        return 5; // return ar[n-1] > max ? ar[n-1] : max;
    }
}

it will always return 5!

answered May 29, 2013 at 14:01

bash.d

13.3k3 gold badges33 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

bash.d Over a year ago

No, it won't... He is passing 5 as second parameter. And 5 != 1 ! In the end, it will hit n == 1 eventually, that is true!

user195488 Over a year ago

there's another small bug.. it will call maximum twice at the end, so that 28 is printed twice... if he comments in that line again

drescherjm Over a year ago

I think the printf in the maximum function was just for debugging purposes.

Ramesh · Accepted Answer · 2013-05-29 14:05:08Z

-4

#include<stdio.h>
void main()
{
    int pin[10]={2,4,6,34,56,54,34,23,1,10},i,max,k;

    max=pin[0];
    for(i=0;i<10;i++)
    {
        if(pin[i]>=max)
        {
            max=pin[i];
            k=i;
        }
    }
    printf("The max number of the array is: %d and it is in  %d position of the array\n",max,k+1);
}

answered May 29, 2013 at 14:05

Ramesh

1631 gold badge2 silver badges11 bronze badges

Collectives™ on Stack Overflow

Finding the maximum element of an array using recursion [closed]

2 Answers 2

3 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Linked

Related