MVC return json info when file not found

Question

i have application where user can download excel report using this button:

<a href="@Url.Action("GetYearlyReport", new {@ViewBag.plantId})"  class="excelIcon" title="Get Yearly Report"></a>

my method looks following:

[HttpPost]
        public ActionResult GetYearlyReport(int plantId)
        {

            string fileName = Reports.GenerateYearlyReport();

            if (!String.IsNullOrEmpty(fileName))
            {
                byte[] fileBytes = GetFile(fileName);

                return File(fileBytes, MediaTypeNames.Application.Octet, fileName);

            }
            return Json(new { Result = "ERROR", Message = "Missing some parameters." });


        }

Now , wheren filename isn't empty then i got the file, but when it is then i am redirected to non existed page GetYearlyReport, while I would like to just say message from json, is that possbile?

ms87 · Accepted Answer · 2013-06-01 17:12:53Z

Why not just add another if() statement to handle the scenarios where file names are empty, and return an error and handle it client side?

        $.ajax({
            url: 'xxx/GetYearlyReport',
            data: { plantId: plantId},
            type: 'POST',
            error: function (xhr, textStatus, exceptionThrown) {
                if (xhr.status == xxx) {
                    alert(xhr.responseText);
                }
            },
            success: function (data) {
                   if(data.Result = 'ERROR'){
                   //do something
                   alert(data.Message);
                   }                    
            }
        });

Or better define a common error handler for your ajax calls?

$(document).ajaxError(function (e, xhr, settings) {
            if (xhr.status == 401)
            {
                alert("unauthorized");
            }
            else if (xhr.status == 0) {
                alert(' Check Your Network.');
            } else if (xhr.status == 404) {
                alert('The resource you are looking for can not be found.');
            } else if (xhr.status == 500) {
                alert('Internel Server Error.');
            } else {
                alert('Unknow Error.\n' + x.responseText);
            }
});

Kambiz Shahim · Accepted Answer · 2013-06-01 17:34:00Z

1

Your code seems fine, I believe redirection is occurred in the Reports.GenerateYearlyReport method, there must be a way to check the result of the method before invoke it.

answered Jun 1, 2013 at 17:34

Kambiz Shahim

2,60016 silver badges21 bronze badges

Collectives™ on Stack Overflow

MVC return json info when file not found

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related