Why "(" is unexpected in bash script?

Question

I have a big problem. My script works well on my Debian Squeeze local VM and Mac OX 10.8 but not on my Debian server ... I checked all the versions of kernel, bash, ... It's the same on all !

My script :

#!/bin/bash
# Version 1.0

ipaddr=$1
datel=$(date +"%d/%m/%Y %k:%M")

function valid_ip() 
{
   local  ip=$ipaddr
   local  stat=1

   if [[ $ip =~ ^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\/[0-9]{1,2}$ ]]; then
      OIFS=$IFS
      IFS='.'
      ip=($ip)
      IFS=$OIFS
      [[ ${ip[0]} -le 255 && ${ip[1]} -le 255 \
          && ${ip[2]} -le 255 && ${ip[3]} -le 255 ]]
      stat=$?
   fi
   return $stat
}

valid_ip
if [ $? -eq "0" ]; then
      nmap -sS -A $ipaddr --max-retries 3 -oX landiscover.xml --webxml 2>> nmap_error.log
      echo "$datel Please wait during discover your network, this operation may take a        while" >> landiscover.log
else
      echo "$datel Please enter a valid network address : XXX.XXX.XXX./XX" >>  landiscover.log
fi
if [ $? -eq "0" ]; then
       echo "$datel Landiscover ran successfully !" >> landiscover.log
fi

When I run this script with debug option I have this output :

loterm_g@vm11:/opt$ sh -x landiscover.sh 192.168.1.0/24
+ 
: not found.sh: 1: 
+ ipaddr=192.168.1.0/24
+ date +%d/%m/%Y %k:%M
+ datel=30/07/2013  1:54
+ 
: not found.sh: 1: 
landiscover.sh: 8: Syntax error: "(" unexpected

Any idea ?

Did you edit the script on a machine that uses CRLF for line endings, instead of Unix LF? I think CR characters are the likely reason for those : not found errors, and probably also the syntax error. — Barmar
– Barmar, Commented Jul 30, 2013 at 0:03
@PaulTomblin No, he's turning it into an array. $(ip) would try to run the ip command and assign its output. — Barmar
– Barmar, Commented Jul 30, 2013 at 0:04
@PaulTomblin No. Shell variables and command names don't conflict with each other. I'll bet anything the problem is CR characters in his script. — Barmar
– Barmar, Commented Jul 30, 2013 at 0:39

glenn jackman · Accepted Answer · 2013-07-30 00:39:21Z

1

You're running the script using the sh interpreter which is not (necessarily) bash, and does not know about arrays.

Also, the error message seem to indicate you have carriage returns in your script. Did you develop it on Windows?

answered Jul 30, 2013 at 0:39

glenn jackman

249k42 gold badges233 silver badges362 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Why "(" is unexpected in bash script?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related