AngularJS : From a factory, how can I call another function

Question

Do I have to move my getTemplates function out of the return or what ?

Example : I dont know what to replace "XXXXXXX" with (I have tried "this/self/templateFactory" etc... ) :

.factory('templateFactory', [
    '$http',
    function($http) {

        var templates = [];

        return {
            getTemplates : function () {
                $http
                    .get('../api/index.php/path/templates.json')
                    .success ( function (data) {
                        templates = data;
                    });
                return templates;
            },
            delete : function (id) {
                $http.delete('../api/index.php/path/templates/' + id + '.json')
                .success(function() {
                    templates = XXXXXXX.getTemplates();
                });
            }
        };
    }
])

AlwaysALearner · Accepted Answer · 2013-08-14 14:39:20Z

38

By doing templates = this.getTemplates(); you are referring to an object property that is not yet instantiated.

Instead you can gradually populate the object:

.factory('templateFactory', ['$http', function($http) {
    var templates = [];
    var obj = {};
    obj.getTemplates = function(){
        $http.get('../api/index.php/path/templates.json')
            .success ( function (data) {
                templates = data;
            });
        return templates;
    }
    obj.delete = function (id) {
        $http.delete('../api/index.php/path/templates/' + id + '.json')
            .success(function() {
                templates = obj.getTemplates();
            });
    }
    return obj;       
}]);

edited Aug 14, 2013 at 14:39

answered Aug 14, 2013 at 14:30

AlwaysALearner

43.9k9 gold badges98 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

zs2020 Over a year ago

There is one more issue, templates = obj.getTemplates(); doesn't work due to the async. You may change the getTemplates to return a promise and then ... you know that :)

HIRA THAKUR · Accepted Answer · 2015-09-08 10:41:58Z

How about this?

.factory('templateFactory', [
    '$http',
    function($http) {

        var templates = [];

        var some_object =  {

            getTemplates: function() {
                $http
                    .get('../api/index.php/path/templates.json')
                    .success(function(data) {
                        templates = data;
                    });
                return templates;
            },

            delete: function(id) {
                $http.delete('../api/index.php/path/templates/' + id + '.json')
                    .success(function() {
                        templates = some_object.getTemplates();
                    });
            }

        };
        return some_object  

    }
])

Collectives™ on Stack Overflow

AngularJS : From a factory, how can I call another function

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related