How to update an iframe with javascript

Question

Hello I am trying to update the src of an iframe with javascript, below is the code I am trying. When I try to execute the code it fails as if an error occured, and stops executing code when I call this line.

document.getElementById('logviewer').src = "www.yahoo.com";

Example code:

<iframe src="" id="logviewer"/>
<script type="javascript/text">
document.getElementById('logviewer').src = "www.yahoo.com";
alert('Loaded Yahoo');
</script>

You can see the src doesn't change and the alert doesn't show.

Thanks ahead of time for your answers!

possible duplicate of Why does jQuery or a DOM method such as `getElementById` not find the element? — Patrick Evans
– Patrick Evans, Commented Aug 25, 2013 at 20:04
There is no duplicate. The code does not run because the type is wrong. — Antti Haapala
– Antti Haapala, Commented Aug 27, 2013 at 4:52

Christian · Accepted Answer · 2013-08-25 20:07:48Z

2

There are some major issues in your code:

script mime-type should be text/javascript not javascript/text
iframe tag should have a closing tag...shortopentags are not supported. This is because contant in between iframe tags is shown when the browser does not support iframes. Your code meant that the script tag ended up in this section instead.
document might not be ready when that code runs (you need to put your code in a domready event), this is basically what Patrick is talking about. I think it's a very relevant cause as well.

Here's your code in a working condition: http://jsfiddle.net/4EMdn/

answered Aug 25, 2013 at 20:07

Christian

28.3k18 gold badges117 silver badges162 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Antti Haapala Over a year ago

the code shouldn't even be executed as javascript if it has an unknown type.

Collectives™ on Stack Overflow

How to update an iframe with javascript

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related