ifstream / ofstream issue with c++?

Question

I have been having a very hard time writing to a binary file and reading back. I am basically writing records of this format

1234|ABCD|efgh|IJKL|ABC

Before writing this record, I would write the length of this entire record ( using string.size()) and then I write the record to the binary file using ofstream as follows:

int size;

ofstream studentfile;
studentfile.open( filename.c_str(),ios::out|ios::binary );
studentfile.write((char*)&size,sizeof(int));
     studentfile.write(data.c_str(),(data.size()*(sizeof(char))));
     cout << "Added " << data << " to " << filename << endl;
     studentfile.close();

And I read this data at some other place

ifstream ifile11;
     int x;
     std::string y;
     ifile11.open("student.db", ios::in |ios::binary);
     ifile11.read((char*)&x,sizeof(int));
     ifile11.read((char*)&y,x);
     cout << "X " << x << " Y " << y << endl;

first I read the length of the record into the variable x, and then read the record into string y. The problem is, the output shows x as being '0' and 'y' is empty.

I am not able figure this out. Someone who can look into this problem and provide some insight will be thanked very much.

Thank you

Some programmer dude · Accepted Answer · 2013-09-20 06:06:09Z

2

You can't read a string that way, as a std::string is really only a pointer and a size member. (Try doing std::string s; sizeof(s), the size will be constant no matter what you set the string to.)

Instead read it into a temporary buffer, and then convert that buffer into a string:

int length;
ifile11.read(reinterpret_cast<char*>(&length), sizeof(length));

char* temp_buffer = new char[length];
ifile11.read(temp_buffer, length);

std::string str(temp_buffer, length);
delete [] temp_buffer;

answered Sep 20, 2013 at 6:06

Some programmer dude

411k36 gold badges420 silver badges655 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sasanka Panguluri Over a year ago

Can you please elaborate? Thank you

Some programmer dude Over a year ago

@SasankaPanguluri Have you tried checking the contents of the file in a hex editor or similar?

Sasanka Panguluri Over a year ago

All I can understand is it's getting written. Can you tell me if there's a way to know it's writing correct data?

Some programmer dude Over a year ago

@SasankaPanguluri You might want to run the writing program in a debugger, and check that the size variable is actually set correctly. Otherwise I usually check these things by doing a hex-dump of the file to see if the file looks to be okay. You should have four bytes for the length, of which the first (or last for big-endian systems) should be non-zero, then followed by your string.

Sasanka Panguluri · Accepted Answer · 2013-09-24 15:44:58Z

0

I know I am answering my own question, but I strictly feel this information is going to help everyone. For most part, Joachim's answer is correct and works. However, there are two main issues behind my problem :

1. The Dev-C++ compiler was having a hard time reading binary files.

2. Not passing strings properly while writing to the binary file, and also reading from the file. For the reading part, Joachim's answer fixed it all.

The Dev-C++ IDE didn't help me. It wrongly read data from the binary file, and it did it without me even making use of a temp_buffer. Visual C++ 2010 Express has correctly identified this error, and threw run-time exceptions and kept me from being misled. As soon as I took all my code into a new VC++ project, it appropriately provided me with error messages, so that I could fix it all.

So, please do not use Dev-C++ unless you want to run into real troubles like thiis. Also, when trying to read strings, Joachim's answer would be the ideal way.

edited Sep 24, 2013 at 15:44

answered Sep 21, 2013 at 6:55

Sasanka Panguluri

3,1484 gold badges35 silver badges54 bronze badges

2 Comments

Orwell Over a year ago

Please don't blindly equate to Dev-C++ to old and buggy. sourceforge.net/projects/orwelldevcpp

Sasanka Panguluri Over a year ago

Sorry if that meant defamation. At one point I was pretty sure. I couldn't help much. The compiler I had on Dev-C++ couldn't, at least read a binary file properly. I am not aware of any exact reason.

Collectives™ on Stack Overflow

ifstream / ofstream issue with c++?

2 Answers 2

4 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related