sqlConnection/Command using statement + try/catch block [duplicate]

Question

What is a correct approach try/catch inside using or using inside try/catch?

using (SqlConnection connection = CreateSqlConnection(connString))
{
               using (SqlCommand command = CreateSqlCommand()
               {
                   try{//open connection + execute command + do something else}
                   catch{//do something}
               }
}

vs.

try
{
    using (SqlConnection connection = CreateSqlConnection(connString))
    {
               using (SqlCommand command = CreateSqlCommand()
               {
                   //open connection + execute command + do something else
               }
    }
}
catch
{
 //do something
}

C Sharper · Accepted Answer · 2014-01-15 09:25:40Z

5

From my point of view:

try
{
    using (SqlConnection connection = CreateSqlConnection(connString))
    {
               using (SqlCommand command = CreateSqlCommand()
               {
                   //open connection + execute command + do something else
               }
    }
}
catch
{
 //do something
}

Above is the correct way.

Because , with this approach if there is exception with connection to database, that will get caught inside catch block.. But with first approach, it will not.

answered Jan 15, 2014 at 9:25

C Sharper

8,66430 gold badges96 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

lemunk Over a year ago

i also agree, but the using statment itself is questionable, doesnt it act similar to the try,catch and finally functions? if so, is there a need to wrap the using functions?

Tim Schmelter Over a year ago

But this doesn't speak against: try{using(...){try{}}}. Also, you are opening the connection in the using-statement and not outside, so why should i surround the using itself with a Try-Catch, that's a different scope. You are in danger to catch too much which is bad.

C Sharper Over a year ago

but incase of choosing from one of the above from my point of view second one is better

DotNetDeveloper · Accepted Answer · 2014-01-15 09:32:37Z

1

Both are correct in the sense that both will close the disposable resources in case of an error.

Where you place the try-catch-statement should depend on what you want to do with that information, i.e. if you want to react to an error concerning the SqlCommand itself or a more general SQL-error, that could also involve the connection.

answered Jan 15, 2014 at 9:32

DotNetDeveloper

4931 gold badge6 silver badges16 bronze badges

Comments

user2046117 · Accepted Answer · 2014-01-15 09:46:11Z

1

Personally, I think the best way is - then the connection is closed regardless and you get to handle the exception as you wish

using (SqlConnection connection = CreateSqlConnection(connString))
{
    using (SqlCommand command = CreateSqlCommand()) 
    {
          try { //open connection, execute }
          catch { // log and handle exception }
          finally { // check connection state and close if required }
    }
}

answered Jan 15, 2014 at 9:46

user2046117

Collectives™ on Stack Overflow

sqlConnection/Command using statement + try/catch block [duplicate]

3 Answers 3

3 Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Linked

Related