Button click not working. - Android

Question

When I click my button in emulator, my application crashes.

Below is my layout.xml:

<Button
    android:id="@+id/button1"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:layout_alignLeft="@+id/textView1"
    android:layout_below="@+id/textView1"
    android:layout_marginTop="40dp"
    android:onClick="loginUser"
    android:text="@string/login_text" />

Here is my method loginUser() in my MainActivity.java:

public void loginUser() {
    Log.d("User Authentication Service", "Trying to login...");
    doLogin(new Intent(getBaseContext(), LoginUserService.class));
}

I've defined which method should be called in my layout.xml using the below line:

   android:onClick="loginUser"

But when I press the button in emulator, application crashes. I've tried changing the above value in layout.xml as show below:

   android:onClick="loginUser()"

But nothing works. What's is wrong?

your method signature is wrong

Raghunandan
– Raghunandan

2014-01-18 18:53:02 +00:00
Commented Jan 18, 2014 at 18:53 — Raghunandan
– Raghunandan, Commented Jan 18, 2014 at 18:53
The debugging messages in your logcat might help.

user2314737
– user2314737

2014-01-18 19:12:04 +00:00
Commented Jan 18, 2014 at 19:12 — user2314737
– user2314737, Commented Jan 18, 2014 at 19:12

Gokul Nath KP · Accepted Answer · 2014-01-18 18:52:09Z

3

You are missing the parameter View in your method signature.

Try changing your code as shown below:

public void loginUser(View view) {
    ...
}

EDIT:

And it should be android:onClick="loginUser" in your layout.xml.

Reference: http://developer.android.com/reference/android/widget/Button.html

answered Jan 18, 2014 at 18:52

Gokul Nath KP

15.6k25 gold badges94 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Button click not working. - Android

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related