VBA Runtime Error 91 Object Variable Not Set - What am I doing wrong?

Question

I am trying to get data from internet to Excel spreadsheet. Namely, I want the names of the AP Top 25 NCAAF teams from past 12 years, for all 17 weeks of the season (including final rankings). My code is based off this tutorial: https://www.youtube.com/watch?v=7sZRcaaAVbg

I'm getting the error at the line:

SchoolNames(iYear, iWeek, iRank) = Trim(Doc.getElementsByTagName("school")(iRank - 1).innerText)

Here's my code:

Option Explicit

Sub Data_Collection()

Application.ScreenUpdating = False

Dim iYear                   As Integer
Dim iWeek                   As Integer
Dim IE                      As New InternetExplorer
Dim sYear                   As String
Dim sWeek                   As String
Dim SchoolNames(12, 17, 25) As String
Dim Doc                     As HTMLDocument
Dim iRank                   As Integer


For iYear = 2002 To 2013

sYear = CStr(iYear)

    For iWeek = 1 To 17

    If iWeek = 17 Then
        sWeek = "1/seasontype/3"
    Else
        sWeek = CStr(iWeek)
    End If

    IE.Visible = False
    IE.navigate "http://espn.go.com/college-football/rankings/_/poll/1/year/" & sYear & "/week/" & sWeek

    Do
        DoEvents
    Loop Until IE.readyState = READYSTATE_COMPLETE

    Set Doc = IE.Document

    For iRank = 1 To 25
        SchoolNames(iYear, iWeek, iRank) = Trim(Doc.getElementsByTagName("school")(iRank - 1).innerText)
    Next iRank

    Next iWeek
Next iYear


End Sub

Additionally, I'm not sure even after I fix the Runtime 91 error that I am passing the right stuff into the .getElementsByTagName(). Any suggestions?

You should pass the tag names, e.g. a, div and etc

sam092
– sam092

2014-02-27 02:24:49 +00:00
Commented Feb 27, 2014 at 2:24 — sam092
– sam092, Commented Feb 27, 2014 at 2:24

Automate This · Accepted Answer · 2014-02-27 04:16:40Z

You are close but need to make a couple small modifications.

SchoolNames(iYear,... iYear variable is a four digit year but you are setting an array so it needs to be the location in the array, not the year)
The element in the webpage that has the school information is labeled by classname not TagName. Change to Doc.getElementsByClassName
Make sure you quite IE so it's not running in the background IE.Quit

Example code for returning Name of school that ranked #1 in 2002 week 1:

Sub getSchoolName()
   Dim IE As New InternetExplorer

   IE.Visible = False
   IE.navigate "http://espn.go.com/college-football/rankings/_/poll/1/year/2002/week/1"

   Do
      DoEvents
   Loop Until IE.readyState = READYSTATE_COMPLETE

   Set Doc = IE.Document

   Dim schoolName As String
   schoolName = Trim(Doc.getElementsByClassName("school")(0).innerText)
   IE.Quit

   MsgBox (schoolName) 
End Sub

Results look like this:

enter image description here

Make sure you include references to in your project.

Here is one way to reset the year as an array position:

sYearCntr = iYear - 2002
SchoolNames(sYearCntr, iWeek, iRank) = ....

Collectives™ on Stack Overflow

VBA Runtime Error 91 Object Variable Not Set - What am I doing wrong?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related