sql query returning only one row

Question

this code is returning only one row from the table , i am unable to figure it out

    <?php
    $sqlrest="Select `restaurant_name` , `restaurant_id` , `menuimage` from  `restaurant` where `restaurant_id` = '".mysql_real_escape_string($_REQUEST['res_id'])."'";
  $result=mysql_query($sqlrest) or die(mysql_error());
      while($row=mysql_fetch_array($result))
      {
      $c=$row['restaurant_name'];
      $id=$row['restaurant_id'];

      <tr>
        <td><?php echo $c ; ?></td>
        <td><img src="image/<?php echo $resid=get::getimage($id); ?>" width="100" height="100" /></td>
        <td><a href="editrestrauntdetails.php?res_id=<?php echo $id ;  ?>">Edit Restraunt Details</a></td>
        <td><a href="restaurantdelete.php?res_id=<?php echo $id ; ?>" onClick="return confirmdelete();">Delete</a></td>
      </tr>
      <?php } ?>

function code that is being used

function getimage($catid) {
$image="select * from `restimage` where `res_id`='$catid'  ";

$imageresult=mysql_query($image) or die(mysql_error()) ;
while($row=mysql_fetch_assoc($imageresult)){
return $getimage=$row['rest_image'];
}
}

because you have a return inside the loop as return $getimage=$row['rest_image']; so it always returns first row. — Abhik Chakraborty
– Abhik Chakraborty, Commented Mar 7, 2014 at 19:52
@AbhikChakraborty i did it something like this $getimage=$row['rest_image']; } return $getimage ; } — user2819264
– user2819264, Commented Mar 7, 2014 at 19:56
You are selecting one row by $_REQUEST['res_id'] from the table "restaurant" — Marcel
– Marcel, Commented Mar 7, 2014 at 19:57
So then, you want all the images for a given restaurant_id, right?? — Hackerman
– Hackerman, Commented Mar 7, 2014 at 19:59
@Marcel but it specifies only condition correct me if i am wrong — user2819264
– user2819264, Commented Mar 7, 2014 at 19:59

Marcel · Accepted Answer · 2014-03-07 20:07:08Z

1

If You want all images from one restaurant. Your Image Function should return all images and return it. Maybe the whole img Tag.

function getimage($catid) {
  $image="select * from `restimage` where `res_id`='$catid'  ";

  $imageresult=mysql_query($image) or die(mysql_error()) ;
  $images = array();
  while($row=mysql_fetch_assoc($imageresult)){
    $images[] = '<img src="image/'. $row['rest_image'] .'" width="100" height="100" />';
  }
  return implode('', $images);
}

answered Mar 7, 2014 at 20:07

Marcel

3751 silver badge8 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

demonking Over a year ago

please change the variablename, this is a bad style us3.php.net/manual/en/reserved.keywords.php

Marcel Over a year ago

@demonking Thanks, i renamed my variable.

user2819264 Over a year ago

@Marcel now it is not returning first row and it echoes width="100" height="100" / this at the end

Collectives™ on Stack Overflow

sql query returning only one row

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related