Android Custom Listview showing wrong data

Question

I have customised list view using BaseAdapter, I want to give separate color for the row position%5 ==0. but it also change the color some other rows which not satisfy the condition. Following is my getView().

public View getView(int position, View convertView, ViewGroup parent) {
    // TODO Auto-generated method stub
    View view=convertView;
    if(convertView==null){
        view=inflater.inflate(R.layout.groupl_ist, null);
    }
    TextView countryName=(TextView) view.findViewById(R.id.tvCountryText);
    ImageView countryImage=(ImageView) view.findViewById(R.id.imgCountry);
    String label=countryNames.get(position);
    countryName.setText(label);

    if(position%5==0){
        countryImage.setVisibility(LinearLayout.GONE);
        view.setBackgroundColor(Color.GREEN);
    }else{
        countryImage.setImageResource(R.drawable.ic_launcher);
    }

    return view;
}

First Change here from countryImage.setVisibility(LinearLayout.GONE); to countryImage.setVisibility(View.GONE); Also use ViewHolder pattern for better performance. — Piyush
– Piyush, Commented Apr 8, 2014 at 12:49

The Hungry Androider · Accepted Answer · 2014-04-08 12:45:48Z

2

It looks like you're having an issue with recycling. You need to implement the ViewHolder pattern. See this link for details on how to implement.

Ultimately what you'll be doing is holding onto the view as you scroll up and down so that it redraws correctly.

answered Apr 8, 2014 at 12:45

The Hungry Androider

2,3005 gold badges27 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Juan Pedro Martinez · Accepted Answer · 2014-04-08 12:47:32Z

2

I am not pretty sure why is happened your problem but try to set to the original color to the rows that don't satisfy the condition. Also, you should implement the ViewHolder pattern. There are a lots post about this pattern.

if(position%5==0){
    view.setBackgroundColor(Color.GREEN);
}else{
    view.setBackgroundColor(Color.WHITE);  //whatever color
}

answered Apr 8, 2014 at 12:47

Juan Pedro Martinez

1,9741 gold badge15 silver badges24 bronze badges

Collectives™ on Stack Overflow

Android Custom Listview showing wrong data

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related