Django ModelForm save() overloading

Question

I am trying to define two different versions of the save() method for a ModelForm, but the only one being executed is the second one. When i try to save() i get error: save() takes at least 3 arguments, 1 given.

[...]
def save(self,commit=True):
    return super(NewProgramForm,self).save(commit=True)

def save(self, NameFile, SizeFile , commit=True):
    inst = super(NewProgramForm, self).save(commit=False)
    inst.size = SizeFile
    inst.sketches_file = NameFile
    inst.lines_of_code = 0

    if commit: inst.save()

    return inst

I'm quite sure the error is trivial, but i can't figure out what's wrong... Thank you in advance for any useful tip!

Ludwik Trammer · Accepted Answer · 2014-05-05 12:40:29Z

1

Defining multiple methods with the same name, but different attributes is called method overloading and is popular in languages such as Java. This is not permitted in Python - plain and simple.

You need to change the name of the second save method, or merge the methods into one method with NameFile and SizeFile having a default value (making them optional).

edited May 5, 2014 at 12:40

answered May 5, 2014 at 12:35

Ludwik Trammer

25.1k7 gold badges70 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

valleymanbs Over a year ago

Thank you very much for your answer! I admit I am a python newbie, and I had this doubt… I'll implement this another way, thanks again for the clarification.

Ludwik Trammer Over a year ago

Sure. One additional tip: There is a strong convention suggesting that pretty much everything that is not a class name (like method attributes) should start with a lowercase letter (more about naming conventions in Python)

valleymanbs Over a year ago

Also, thanks for completing the answer with a suggestion for the implementation. Answer accepted, you're very kind!

Collectives™ on Stack Overflow

Django ModelForm save() overloading

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related