Ruby Array of Hashes of Hashes Map

Question

I have this hash,

[{ "player" => { "name" => "Kelvin" , "id" => 1 } , "player" => { "name" => "David",  
   "id" => 2 }]

I checked if each event contains the keys [id,name] with the following line in my Rspec,

json_response.map{|player| ["name","id"].all? {|attribute| player["player"].key? 
  (attribute)}}.should_not include(false)

which works perfectly. How can I simplify this and make it more efficient?

What you show is not a hash. It is not even valid Ruby object. I cannot parse "Array of Hashes of Hashes Map" in your title. — sawa
– sawa, Commented May 26, 2014 at 9:27

Intrepidd · Accepted Answer · 2014-05-26 10:32:38Z

3

How about :

json_response.each do |event|
  event['player'].should have_key('name')
  event['player'].should have_key('id')
end

Much clearer IMHO

Edit : if you need to check a lot of columns :

json_response.each do |event|
  ['name', 'id', 'foo', 'bar', 'baz'].each do |column|
    event['player'].should have_key(column)
  end
end

answered May 26, 2014 at 9:20

Intrepidd

21.2k7 gold badges59 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nice one. But If I need to check like, 10 columns, how can I DRY the code then?

Uri Agassi · Accepted Answer · 2014-07-06 08:23:33Z

0

According to the documentation you should be able to do this:

json_response.each do |event|
  event['player'].should include('name', 'id')
end

answered May 26, 2014 at 11:04

Uri Agassi

37.5k16 gold badges82 silver badges96 bronze badges