How to test a specific line in a rails model using rspec

Question

I have a model with an initializer in it, which basically creates a user from a user hash.

After it gets the user information, it checks whether the "privileges" key in the hash is an array. If it's not, it turns it into an array.

Now the obvious way of doing this would be crafting an entire user_hash so that it would skip those "create user" lines and then check if it turns the input into an array if necessary. However, I was wondering if there is a more DRY way of doing this?

Here is the user model I'm talking about:

def initialize(opts={})
  @first_name = opts[:user_hash][:first]
  @last_name = opts[:user_hash][:last]
  @user_name = opts[:user_hash][:user_name]
  @email = opts[:user_hash][:email]
  @user_id = opts[:user_hash][:id]

  @privileges = {}

  if opts[:privs].present?
    if !opts[:privs].kind_of?(Array)
      opts[:privs] = [opts[:privs]]
    end
  end
end

yes, I just trimmed the irrelevant code but basically it's used to set the privileges for the user. — hasancc
– hasancc, Commented Jul 11, 2014 at 12:07

Uri Agassi · Accepted Answer · 2014-07-11 11:53:18Z

2

You can pass a double which returns the needed value when the proper key is requested, and itself (or something else) otherwise:

it 'turns privs into an array' do
  opts = double(:opts)
  allow(opts)to receive(:[]).and_return(opts)
  allow(opts)to receive(:[]).with(:privs).and_return('not array')

  expect(MyClass.new(opts).privileges).to eq(['not array'])
end

Btw, your code could be simplified using the splat operator:

privs = [*opts[:privs]]

sample behavior:

privs = nil
[*privs]
# => []

privs = ['my', 'array']
[*privs]
# => ["my", "array"]

privs = 'my array'
[*privs]
# => ["my array"]

answered Jul 11, 2014 at 11:53

Uri Agassi

37.5k16 gold badges82 silver badges96 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

nronas · Accepted Answer · 2014-07-11 12:12:04Z

0

You can even use the idempotent Kernel#Array

def initialize(opts = {})
  @first_name = opts[:user_hash][:first]
  @last_name = opts[:user_hash][:last]
  @user_name = opts[:user_hash][:user_name]
  @email = opts[:user_hash][:email]
  @user_id = opts[:user_hash][:id]
  @privileges = {}

  Array(opts[:privs])
end

I hope that helps

answered Jul 11, 2014 at 12:12

nronas

1814 bronze badges

Comments

Stefan · Accepted Answer · 2014-07-11 12:27:31Z

0

Rather than testing the implementation (value is turned into an array), I would test the desired behavior (takes single privilege or multiple privileges):

describe User do

  describe '#initialize' do

    it "takes single privilege" do
      user = User.new(user_hash: {}, privs: 'foo')
      expect(user.privileges).to eq(['foo'])
    end

    it "takes multiple privileges" do
      user = User.new(user_hash: {}, privs: ['foo', 'bar'])
      expect(user.privileges).to eq(['foo', 'bar'])
    end

  end

end

answered Jul 11, 2014 at 12:27

Stefan

115k14 gold badges157 silver badges234 bronze badges

Collectives™ on Stack Overflow

How to test a specific line in a rails model using rspec

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related