express.js: Route Function not called express.js

Question

My express.js configuration looks like this:

//app.js:
var routes = require('./routes/index');
app.use(express.static(path.join(__dirname, '../client/build'), {'index': false}));
app.use('/', routes);

//routes/index.js:
router.get('/', function(req, res) {
 console.log("im never called");
});

My handler is NEVER called (should be called when requesting without path or just '/'), the browser just gets a 303 with Location //, what is wrong here?

Thanks in advance for help!

Can you show your full routes/index.js file? What are you exporting? Where does router come from? Etc. .. — mscdex
– mscdex, Commented Aug 3, 2014 at 15:31
var express = require('express'); var router = express.Router(); module.exports = router; there is not more in my index.js. Different routes get called, its just this one route. — user2071301
– user2071301, Commented Aug 3, 2014 at 15:38

Oleg · Accepted Answer · 2014-08-03 16:06:47Z

1

Try to add module.exports = router; to the end of routes/index.js

Edit:

There is a common practice to put all your static files in one directory (maybe you have done it already) and make all requests to static files start with /public:

app.use('/public', express.static(path.join(__dirname, '../client/build'));

Doing this way

http://yoursite.com/public/some/file.js

will be served with

../client/build/some/file.js

Instead of /public you may choose a path that will not intersect with your router.

edited Aug 3, 2014 at 16:06

answered Aug 3, 2014 at 15:46

Oleg

23.5k10 gold badges72 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user2071301 Over a year ago

Sorry for being unclear, I already did that. When I remove serving of static files the route is called.

user2071301 Over a year ago

well its bsaically the same as this: stackoverflow.com/questions/16088824/… .. guess I have to rename the index.html or remove it from being served..

Oleg Over a year ago

As an alternative, you can put app.use(express.static...) after app.use('/', routes);

user2071301 Over a year ago

I tried that, but then my route handler intercept all static requests :/

JRulle · Accepted Answer · 2016-04-18 14:28:01Z

1

I was having this same issue this morning and I thought I would share my solution.

The express.static method is running on all of your requests... when it cannot find a match, it can either run the next() function and continue to your desired handler or redirect to a trailing slash to check if the request is for a directory.

I fixed it by adding 'redirect:false' as follows:

app.use(express.static(
    path.join(__dirname, '../client/build'), 
    {index: false, redirect: false}));

Reference: express.static(root, [options])

answered Apr 18, 2016 at 14:28

JRulle

7,5666 gold badges42 silver badges63 bronze badges

Collectives™ on Stack Overflow

express.js: Route Function not called express.js

2 Answers 2

4 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related