Inserting array of Ids in Codeigniter

Question

I'm trying to insert two rows but the id of every row is in the same array, how can I insert correctly?

Because I tried by this way but only insert me the first id.

$sql = "
    INSERT INTO cars(car, price, createdDate, createdBy) 
    VALUES (".$this->db->escape($ids).",
            ".$this->db->escape($price).",
            NOW(),
            ".$this->session->userdata('admin_id').")";             

    mysql_query($sql);
    echo ($sql);

This is what I get:

INSERT INTO cars (car, price, createdDate, createdBy) 
VALUES ('217450,217449', '15', NOW(), 150)

In car I want to insert the price, createdDate and createdBy on the two car Ids 217450,217449.

Thank you in advance.

use explode function to make it as separate array and insert.... — Torrezzzz
– Torrezzzz, Commented Aug 6, 2014 at 7:32

Parag Tyagi · Accepted Answer · 2014-08-06 07:44:51Z

1

$ids = "217450, 217449";
$id_explode = explode(",", $ids);

foreach($id_explode as $id)
{
    $sql = "
             INSERT INTO cars(car, price, createdDate, createdBy) 
             VALUES (".$this->db->escape($id).",
             ".$this->db->escape($price).",
             NOW(),
             ".$this->session->userdata('admin_id').")
           ";             

   mysql_query($sql);
   echo ($sql);
}

But I recommend you not to use raw SQL queries as it is vulnerable to SQL injection.
Hence, Use CI's active record:

$ids = "217450, 217449";
$id_explode = explode(",", $ids);

$insert_batch = array();
foreach($id_explode as $id)
{
    $arr = array(
              'car' => $id,
              'price' => $price,
              'createdDate' => NOW(),
              'createdBy' => $this->session->userdata('admin_id'),
             );
    $insert_batch[] = $arr;
}

$this->db->insert_batch('cars', $insert_batch);

Documentation:

https://ellislab.com/codeigniter/user-guide/database/active_record.html

edited Aug 6, 2014 at 7:44

answered Aug 6, 2014 at 7:37

Parag Tyagi

9,0003 gold badges45 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Parag Tyagi Over a year ago

Happy to help. Also recommended a suggestion.

Ganesh Jadhav · Accepted Answer · 2014-08-06 07:36:22Z

1

Use PHP function explode:

$ids= explode(',', $ids);
foreach($ids as $id)
{
    $sql = "INSERT INTO cars(car, price, createdDate, createdBy) 
        VALUES (" . $this->db->escape($id) . ", " . $this->db->escape($price)
        . ", NOW(), " . $this->session->userdata('admin_id') . ")";
    mysql_query($sql);
}

answered Aug 6, 2014 at 7:36

Ganesh Jadhav

2,8481 gold badge22 silver badges34 bronze badges

Comments

codeGig · Accepted Answer · 2014-08-06 07:39:44Z

1

If you use ids as array like $ids = array('217450','217449');

$sql = "
INSERT INTO cars(car, price, createdDate, createdBy) 
VALUES ";
foreach($ids as $id){

$sql .=(".$this->db->escape($id).",
        ".$this->db->escape($price).",
        NOW(),
        ".$this->session->userdata('admin_id')."),";             
}
mysql_query($sql);
echo ($sql);

Now it will create query

 INSERT INTO cars (car, price, createdDate, createdBy)
VALUES ('217450', '15', NOW(), 150),('217450', '15', NOW(), 150);

answered Aug 6, 2014 at 7:39

codeGig

1,0841 gold badge8 silver badges11 bronze badges

Collectives™ on Stack Overflow

Inserting array of Ids in Codeigniter

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related