std::remove_if usage in C++98

Question

I was looking for a smart way of erasing some elements in a vector while iterating, and found this question.

Of course, it won't work for me, since C++98 doesn't have lambdas. Looked for remove_if info and found this at cppreference. So this is how my code looks:

#include <algorithm>
#include <vector>

bool isOutageValid(const Outage& outage){
    return outage.getEndTime() >= 0;
}

std::vector<Outage> outages;
// Some stuff to fill the vector

outages.erase(std::remove_if(outages.begin(), outages.end(), isOutageValid));

for(vector<Outage>::iterator o=outages.begin(); o!=outages.end(); o++){
    std::cout << o->getStartTime() << " " << o->getEndTime() << std::endl;
}

I am debugging with 4 Outages into a vector, where I know the first is invalid and the rest of them valid. After executing the erase, the vector size is 3, so it looks ok. But if I iterate with the for loop to inspect the 3 Outages into the vector, the second one has been erased instead of the first.

I even debugged the isOutageValid method, and it is the first the only one who is returning false. Is there any mistake I'm missing?

you meant outages.begin(), right?

taocp
– taocp

2014-08-25 14:18:38 +00:00
Commented Aug 25, 2014 at 14:18 — taocp
– taocp, Commented Aug 25, 2014 at 14:18

Jarod42 · Accepted Answer · 2014-08-25 14:19:38Z

7

It should be:

outages.erase(std::remove_if(outages.begin, outages.end(), isNotOutageValid), outages.end());

Currently, you partition outages not valid first, valid last (in other words, your predicate is inverted).
And then remove the fist valid element (instead of a range).

answered Aug 25, 2014 at 14:19

Jarod42

228k15 gold badges214 silver badges351 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

fredoverflow Over a year ago

+1 I have been bitten more than once by leaving out the second , outages.end()...

Piotr Skotnicki · Accepted Answer · 2014-08-25 14:25:30Z

4

1.You forgot to specify the second argument of erase, which is the end of the range which is erased:

outages.erase(std::remove_if(outages.begin, outages.end(), isOutageValid), outages.end());

2.The condition is invalid, you should negate it:

 #include <functional>

 outages.erase(std::remove_if(outages.begin, outages.end(), std::not1(std::ptr_fun(&isOutageValid))), outages.end());

edited Aug 25, 2014 at 14:25

answered Aug 25, 2014 at 14:19

Piotr Skotnicki

48.8k7 gold badges122 silver badges167 bronze badges

1 Comment

fredoverflow Over a year ago

+1 I have been bitten more than once by leaving out the second , outages.end()...

Collectives™ on Stack Overflow

std::remove_if usage in C++98

2 Answers 2

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related