How do I put multiple rows of a MySQL database into a multidimensional array (PHP)?

Question

I am working on a system where a query checks the database for records matching multiple ids and puts each row into it's own array. So far I only got the last row to echo out in it's own array. Here is the query code:

$query = "SELECT * FROM messages WHERE senderid IN ($senderids) ORDER BY messageid DESC";
$resource = mysql_query($query, $database);
$result = mysql_fetch_array($resource);
foreach($result as $result1)
    {
    print_r($result1);
    echo '<br>';
    }

This is what echos in the browser:

2
2
1
1
TEST MSG 2
TEST MSG 2
2014_09_13_01:29:59
2014_09_13_01:29:59

This is what should echo:

Array ([messageid] => 1 [senderid] => 1 [message] => test message [date] => 2014_09_13_01:01:09)
Array ([messageid] => 2 [senderid] => 1 [message] => TEST MSG 2 [date] => 2014_09_13_01:29:59)

How would I go about fixing this issue?

just for fyi....your code is open for sql injection...search for mysqli_ or PDO queries. — NoobEditor
– NoobEditor, Commented Sep 13, 2014 at 6:29
@NoobEditor The $senderid variable is escaped using mysql_real_escape_string earlier in the code. — rn10950
– rn10950, Commented Oct 16, 2014 at 1:34

Rob M. · Accepted Answer · 2014-09-13 06:09:24Z

1

mysql_fetch_array does not return the whole result set, just the row at the current cursor. Your code isn't moving the mysql cursor; to do that, your code should be:

$resource = mysql_query($query, $database);
while($row = mysql_fetch_array($resource)){
  print_r($row);
  echo '<br />';
}

Also, for the desired output you posted, you should use mysql_fetch_assoc instead as it will be a hash with column names instead of an indexed array

answered Sep 13, 2014 at 6:09

Rob M.

36.6k6 gold badges56 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

vinod · Accepted Answer · 2014-09-13 06:23:53Z

0

$query = "SELECT * FROM messages WHERE senderid IN ($senderids) ORDER BY messageid DESC";
$resource = mysql_query($query, $database);
while($result = mysql_fetch_array($resource))
{
print_r($result);    // OR $array[] = $result; and print $array outside the while loop 
}

answered Sep 13, 2014 at 6:23

vinod

2,8901 gold badge20 silver badges23 bronze badges

Collectives™ on Stack Overflow

How do I put multiple rows of a MySQL database into a multidimensional array (PHP)?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related