C#: Is this the correct way to use the SqlDataReader for DAAB

Question

I have just started using the Data Access Application Block from microsoft. There are very few instructions on the correct way to use the library. Just wanted to know if this is the correct way to use the data reader.

SqlDataReader reader = SqlHelper.ExecuteReader(config.ConnectionString, CommandType.Text, "select * from category");
List<string> a = new List<string>();
using (reader)
{
     while (reader.Read())
     {
          string t = reader.GetString(1);
          a.Add(t);
     }

     return a;
}

will everything get closed doing it this way? Is there any chance of memory leaks?

The latest release (v6) on CodePlex now has some very well written documentation, explanations and sample code. See entlib.codeplex.com/releases and in particular the "Developer’s Guide to Microsoft Enterprise Library" which can be downloaded as a pdf and explains DAAB usage and rationale very well. — mdisibio
– mdisibio, Commented Aug 31, 2013 at 6:07

AJ. · Accepted Answer · 2010-04-06 17:17:55Z

Put your reader initialization into the using block, and I would avoid using column numbers if you can, as they essentially turn into magic numbers. Unfortunately, that just requires you use the column names, but I have found that column names are less likely to change than column offsets, and you can always put your column names in a configuration file or something. Also, make sure you take into account the possibility for null columns

using(var reader = SqlHelper.ExecuteReader(etc. etc. etc.))
{
    while(reader.read()){
    {
        //Only need to do this if you don't want your string to be null
        //and if the "columnName" column is nullable.
        var stringValue = reader.IsDBNull(reader.GetOrdinal("columnName") 
                        ? "" 
                        : reader.GetString(reader.GetOrdinal("columnName"));
        a.Add(stringValue);
    }
}

Adriaan Stander · Accepted Answer · 2010-04-06 17:01:51Z

0

HAve a look at

The Enterprise Library Data Access Application Block, Part 2

answered Apr 6, 2010 at 17:01

Adriaan Stander

167k32 gold badges294 silver badges288 bronze badges

Collectives™ on Stack Overflow

C#: Is this the correct way to use the SqlDataReader for DAAB

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related