Undefined variables used in CodeIgniter model method [duplicate]

Question

Both variables are undefined($usuario and $senha)

This code is supposed to do login, but the model isn't receiving the variables.

Model

public function login()
{ 
    $query = $this->db->query("SELECT * FROM usuario WHERE login = '$usuario' AND senha = '$senha'");
    $query = $query->result();
    return $query;
}

To format code, highlight the block, and click the {} button (not the "" button). — gen_Eric
– gen_Eric, Commented Oct 9, 2014 at 19:37
You need to pass $usuario and $senha to the login() function as parameters. — gen_Eric
– gen_Eric, Commented Oct 9, 2014 at 19:38

sjagr · Accepted Answer · 2014-10-09 19:43:46Z

There's an indication from these two lines:

$this->Usuario_model->usuario = $this->input->post('usuario');
$this->Usuario_model->senha = sha1($this->input->post('senha'));

that there are variables inside of the Usuario-model that you have accessed and stored, but the login() function is trying to access variables inside of the scope of the function, not the scope of the model. Using $this-> will allow you to access the private, public, or protected variables of the class that the function lives in. Make sure you try:

public function login(){ 
    $query = $this->db->query("SELECT * FROM usuario WHERE login = '".$this->usuario."' AND senha = '".$this->senha."'");
    $query = $query->result();
    return $query;
}

To use a PDO-like approach, as per the CI docs, you should instead do:

public function login() {
    $query = $this->db->query(
        'SELECT * FROM usuario WHERE login = ? AND senha = ?',
        array($this->usuario, $this->senha)
    )
    $query = $query->result();
    return $query;
}

This will give you safer queries with escaped user values.

Collectives™ on Stack Overflow

Undefined variables used in CodeIgniter model method [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related