Simple Javascript Calculator, something went wrong?

Question

I tried to make this simple JS calculator following a tutorial I found but it doesn't seem to be working at all. When I press one of the buttons nothing happens. I probably made a really stupid mistake so I'm sorry if I'm wasting your time. I've troubleshooted it but I can't find a solution.

Correction: It works now!

var a,b,result;
    function setValues()
    {
    	a = Number(document.getElementById("a").value);
    	b = Number(document.getElementById("b").value);
    }
    
    function sum()
    {
    	setValues();
    	result = a+b;
    	alert("The sum is equal to"+result);
    }
    
    function rest()
    {
    	setValues();
    	result = a-b;
    	alert("The rest is equal to"+result);
    }
    
    function mult()
    {
    	setValues();
    	result = a*b;
    	alert("The mult is equal to"+result);
    }
    
    function div()
    {
    	setValues();
    	result = a/b;
    	alert("The div is equal to"+result);
    }

<div>
  <input id="a" type="text">
  <input id="b" type="text">
  <input type="button" onclick="sum()" value="sum"/>
  <input type="button" onclick="rest()" value="rest"/>
  <input type="button" onclick="mult()" value="multiply"/>
  <input type="button" onclick="div()" value="divide"/>

</div>

what errors are you seeing? anything in your console? is anything being alerted? (n.b use parseInt() rather then Number()) — atmd
– atmd, Commented Jan 5, 2015 at 11:21
I've voted to close this as it's a simple typographical error. getElementByID should be getElementById. — James Donnelly
– James Donnelly, Commented Jan 5, 2015 at 11:24

Justinas · Accepted Answer · 2015-01-05 11:24:12Z

1

You can check that your console (F12) is throwing error.

Change

document.getElementByID("a").value

to

document.getElementById("a").value

JavaScript is Case-Sensitive. So that's why js does not find getElementByID

answered Jan 5, 2015 at 11:24

Justinas

43.9k5 gold badges72 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Thomas Junk · Accepted Answer · 2015-01-05 11:24:16Z

0

Typo?

a = Number(document.getElementByID("a").value);
b = Number(document.getElementByID("b").value);

Try:

a = Number(document.getElementById("a").value);
b = Number(document.getElementById("b").value);

answered Jan 5, 2015 at 11:24

Thomas Junk

5,6962 gold badges34 silver badges48 bronze badges

3 Comments

Rohit Aggarwal Over a year ago

I create a fiddle for same, jsfiddle.net/ucrjp9yn, made the "ID" to "Id" change, but it's still not working, are you sure the problem is that only?

Thomas Junk Over a year ago

@RohitAggarwal yes. The problem in your case is jsfiddle itself. Copy and Paste it into a local file and fire up your favourite browser and it should work.

kingkapd Over a year ago

Yes, run the snippet above and try for yourself if you want!

Collectives™ on Stack Overflow

Simple Javascript Calculator, something went wrong?

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related