Simple Batch In For Loop Not Working

Question

My goal is to convert some files with *.cdr extension to *.ai in a directory. The files look like file_a.cdr. file_b.cdr ...... I have replaced the convert.exe for you to another simple command like copy, so don't ask about the sense here in my example.

    setlocal enableDelayedExpansion
    for %%f in (*.cdr) do (
    set "infile=%%f"
    set "outfile=%%~nf.ai"
    copy "%infile%" "%outfile%"
    )

The output of the batch is always different!!!!

Sometimes it is:

copy "%file_a.cdr" "%file_a.ai" => system cannot find file

or

copy "" "" => system cannot find file

I have already used this syntax copy !infile! !outfile! with now success:

Thx in advance

MC ND · Accepted Answer · 2015-02-12 16:54:41Z

4

You don't need the variables

for %%f in (*.cdr) do (
    convert "%%f" "%%~nf.ai"
)

Or, if you are trying to do it from command line,

for %f in (*.cdr) do convert "%f" "%~nf.ai"

as inside batch files percent signs need to be escaped, but this is not the case for command line.

answered Feb 12, 2015 at 16:54

MC ND

71.1k8 gold badges95 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

GolezTrol Over a year ago

Ah, I understand now what the 'convert.exe' phrase was about.

John Castleman Over a year ago

This is the right answer. Accepting Answers.

Mohit Atray · Accepted Answer · 2017-06-07 11:40:35Z

0

Use delayed expansion. And surround your variables by ! instead of %

edited Jun 7, 2017 at 11:40

answered Jun 4, 2017 at 17:01

Mohit Atray

4504 silver badges15 bronze badges

Collectives™ on Stack Overflow

Simple Batch In For Loop Not Working

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related