Instance of class in constructor

Question

I'm not sure with my approach. A have two classes and call functions of first class in second class like this:

class A {

    public function aClassFunction() {...}

}


class B {

    private $aClass;

    public function __construct() {
        $this->aClass = new A();
    }

    public function bClassFunction() {
        $test = $this->aClass->aClassFunction();
    }
}

It just works, but looks "suspiciously".

As you said: it works. But if you want you can just use extends like: class B extends A and then you can use the function from the class A in class B — Rizier123
– Rizier123, Commented Feb 16, 2015 at 19:51
why not extend or better yet pass A as a dependency, through B's constructor? Theres even traits.. try abit more reasearch — Lawrence Cherone
– Lawrence Cherone, Commented Feb 16, 2015 at 19:52

Piotr Olaszewski · Accepted Answer · 2015-02-16 19:51:53Z

1

You can use dependency injection in B class. That approach helps you mocking classes in test.

class B {

    private $aClass;

    public function __construct(A $a) {
        $this->aClass = $a;
    }

    public function bClassFunction() {
        $test = $this->aClass->aClassFunction();
    }
}

$b = new B(new A());

answered Feb 16, 2015 at 19:51

Piotr Olaszewski

6,2485 gold badges40 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

AbraCadaver · Accepted Answer · 2015-02-16 19:52:16Z

1

Looks "suspiciously" like a dependency. Why not Inject the Dependency?

class B {

    private $aClass;

    public function __construct($object) {
        $this->aClass = $object;
    }

    public function bClassFunction() {
        $test = $this->aClass->aClassFunction();
    }
}

answered Feb 16, 2015 at 19:52

AbraCadaver

79.2k7 gold badges75 silver badges91 bronze badges

Collectives™ on Stack Overflow

Instance of class in constructor

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related