Java template function

Question

I have a function that sometimes has to return a Date other times a DateTime (Joda-Time).

static public <T extends Object> T convertTimeForServer(DateTime toSave) {
    DateTime temp = null;
    try {
        temp = toSave.withZone(DateTimeZone.forID(getServerTimeZone()));
    } catch (Exception e) {
    }

    T toReturn = null;
    if (toReturn.getClass().equals(temp)) {
        return (T) temp;//Return DATETIME
    } else {
        return (T) temp.toDate();//Return DATE
    }
}

Is it the right approach?
How to use it?

like this (timerHelper is the name of class):

DateTime t = timerHelper.<DateTime>convertTimeForServer(new DateTime());
Date t2 = timerHelper.<Date>convertTimeForServer(new DateTime());

or

DateTime t = (DateTime)timerHelper.convertTimeForServer(new DateTime());
Date t2 = (Date)timerHelper.convertTimeForServer(new DateTime());

And how to use this function instead?

static public <T extends Object> T current_Moment(){
    return convertTimeForServer(new DateTime());
}

No because in the code sometimes I need a Date other times a DateTime — user72708
– user72708, Commented Jun 19, 2015 at 13:36
Well, in those times when you need a date, call t.toDate(). — RealSkeptic
– RealSkeptic, Commented Jun 19, 2015 at 13:37
toReturn.getClass() will always throw a NullPointerException — NickJ
– NickJ, Commented Jun 19, 2015 at 13:37
you can just return DateTime always and manipulate it afterward to fit your needs, whats complicated about that! — Ahmad Al-Sanie
– Ahmad Al-Sanie, Commented Jun 19, 2015 at 13:37

Danikov · Accepted Answer · 2015-06-19 14:18:39Z

6

I suspect you're being too clever trying to use generics here. Because you don't have polymorphism on return types doesn't mean you should resort to generics to try and achieve that effect.

You can implement this simply as two methods: public static Date convertToDateForServer(DateTime toSave) {...} and public static DateTime convertToDateTimeForServer(DateTime toSave) {...}. The calling code seems to know what it wants, so it can simply call the method needed. If there really is a complex commonality to both methods, make a private method that both can call internally.

answered Jun 19, 2015 at 14:18

Danikov

7453 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 12:05:55Z

2

If Java 8 is available you could always implement an Either using the new Optional class.

edited May 23, 2017 at 12:05

CommunityBot

11 silver badge

answered Jun 19, 2015 at 13:42

OldCurmudgeon

66.1k18 gold badges126 silver badges220 bronze badges

Comments

NickJ · Accepted Answer · 2015-06-19 13:44:22Z

2

This is one of the tricky areas of Generics. The only way to get this to work would be to take a Class argument, so the method knows what type of object to create. It can't know at the moment, because of Type Erasure.

Alternatively (much simpler) is to always return DateTime and do away with generics here.

The client will always know what it wants, and if the client wants a Date, it can create one from the DateTime far more easily than what you are trying to do.

Example:

Client 1 wants a DateTime:

DateTime result = service.convertTimeForServer(dt);

Client 2 wants a Date:

Date result = service.convertTimeForServer(dt).toDate();

answered Jun 19, 2015 at 13:44

NickJ

9,6399 gold badges53 silver badges80 bronze badges

Collectives™ on Stack Overflow

Java template function

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related