Using a loop to set the buttons onclicklistener

Question

I am trying to use a loop to set the action for each button when clicked (since most of the buttons will just return their text value), however I am getting an error stating "variable 'i' is accessed from within inner class, needs to be declared final". How can I get around this?

Here is what I got

String getValuesPressed(){

    for(int i = 0; i < buttonList.length; i++){

        buttonList[i].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {

                if(i == 0){//error occurs here
                    //do stuff
                }

            }
        });
    }
    return textOnScreen;
}

Sanjeet A · Accepted Answer · 2015-08-08 09:15:49Z

13

You can copy the value of i in to a temp final variable as -

for (int i = 0; i < buttonList.length; i++) {
        final int finalI = i;
        buttonList[i].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                if (finalI == 0) {//error occurs here
                    //do stuff
                }
            }
        });
    }

answered Aug 8, 2015 at 9:15

Sanjeet A

5,2374 gold badges26 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kai · Accepted Answer · 2015-08-08 09:19:49Z

You are creating an anonymous class (View.OnClickListener) for each button, the onClick() method within that class has a different scope than the method getValuesPressed(), therefore it has no access to local variable i.

The solution is contained within the link provided above:

An anonymous class cannot access local variables in its enclosing scope that are not declared as final or effectively final.

Therefore introducing a final variable into the loop would resolve the error:

String getValuesPressed(){

    for(int i = 0; i < buttonList.length; i++){
        final int j = i;
        buttonList[i].setOnClickListener(new View.OnClickListener() {
            @Override 
            public void onClick(View v) {

                if(j == 0){//error occurs here
                    //do stuff 
                } 

            } 
        }); 
    } 
    return textOnScreen; 
}

Eoin · Accepted Answer · 2015-08-08 09:23:40Z

1

You could create you own listener that takes the position as a parameter to workaround the fact you are using an anonymous inner class.

private class MyClickListener implements View.OnClickListener {

    int position;

    public MyClickListener (int position) {
        this.position = position;
    } 

    @Override 
    public void onClick(View v) {
        if(position == 0){
            //do stuff 
        } 
    } 
}

Then in your loop you can create it like this

String getValuesPressed(){

    for(int i = 0; i < buttonList.length; i++){
        buttonList[i].setOnClickListener(new MyClickListener(i)); 
    } 

    return textOnScreen; 
}

answered Aug 8, 2015 at 9:23

Eoin

4,0662 gold badges36 silver badges43 bronze badges

Collectives™ on Stack Overflow

Using a loop to set the buttons onclicklistener

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related