Update MySQL entry through PHP form

Question

I am writing a script right now to update a MySQL data entry through a PHP form. I know there are lots of tutorials and also a lot of answers here on Stackoverflow. My problem is that I get a "Updated data successfully" message but the data are not updated inside my database. Maybe someone find the error or can tell me what I did wrong and what I have to change. Here is the needed code:

Form:

<?php 
session_start();

if(empty($_SESSION)) // if the session not yet started
   session_start();

if(!isset($_SESSION['email'])) { //if not yet logged in
   header("Location: login.php");// send to login page
   exit;
}

include 'header.php';

$get = "SELECT * FROM user email WHERE email = '".$_SESSION['email']."'";
 $result_get = mysqli_query($connect, $get);
 $_SESSION['data'] = mysqli_fetch_assoc($result_get);

?>
    <form method="POST" action="update_profile.php" class="form-horizontal form-label-left">

    <div class="form-group">
    <label class="control-label col-md-3 col-sm-3 col-xs-12">Vorname:</label>
    <div class="col-md-9 col-sm-9 col-xs-12">
    <input type="text" name="firstname_parent" class="form-control" value="<?php echo $_SESSION['data']['firstname_parent']; ?>">
    </div>
    </div>
    <button type="submit" name="update" value="update" class="btn btn-warning btn-lg btn-block">PROFIL VERVOLLSTÄNDIGEN</button>
   </form>

update_profile.php:

    <?php
session_start();
// Create connection credentials
$db_host = 'localhost';
$db_name = 'DBNAME';
$db_user = 'DBUSER';
$db_pass = 'DBPASS';

// Create mysqli object
$connect = new mysqli ($db_host, $db_user, $db_pass, $db_name);

// Error Handler
if ($connect->connect_error) {
    printf ("Connection failed: %s\n", $connect->connect_error);
    exit();
}   

// Check if form is submitted
if (isset ($_POST['update'])) {
    $update_firstname_parent = mysqli_real_escape_string ($connect, $_POST['firstname_parent'] );
}


$sql = mysqli_query ($connect, "UPDATE `user` SET 
     firstname_parent='".$update_firstname_parent."'  WHERE email = '".$_SESSION['email']."'";

if (mysqli_affected_rows($connect) == 0) //<--
{
    die('Could not update data: ' . mysql_error());
} else {
    echo "Updated data successfully\n";
}
mysql_close($connect); 

?>

EDIT: I changed the update_profile.php due to some comments here. Now I do not get a "Updated data successfully" message, now I only get a blank page and no data is updated inside the database.

Thanks, Chris

Besides your update query being wrong, it seems that you inverted the success/failure messages. — Robby Cornelissen
– Robby Cornelissen, Commented Aug 25, 2015 at 8:11
@099 thanks for your tip, I tried it but same effect. I get the message "Updated data successfully" but no change inside my database — Christoph C.
– Christoph C., Commented Aug 25, 2015 at 8:12
in update_profile.php you have this "UPDATE user WHERE email = '".$_SESSION['email']."... - I can't see session_start(); at the top of the page ! perhaps that's the problem ? — Peter Blue
– Peter Blue, Commented Aug 25, 2015 at 8:13

Harshit · Accepted Answer · 2015-08-25 08:16:04Z

1

Your update query is wrong. Change it

$sql = mysqli_query ($connect, "UPDATE `user` WHERE email = '".$_SESSION['email']."' (`firstname_parent`) 
        VALUES ('$update_firstname_parent')");

to

$sql = mysqli_query ($connect, "UPDATE `user` SET 
     firstname_parent='".$update_firstname_parent."'  WHERE email = '".$_SESSION['email']."'");

edited Aug 25, 2015 at 8:16

answered Aug 25, 2015 at 8:09

Harshit

5,18711 gold badges51 silver badges96 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Christoph C. Over a year ago

Thanks for your code. I tried this query. Now I only get a blank page. No "Updated data successfully" message or any error message. Also nothing has changed inside the database.

Harshit Over a year ago

@ChristophC., Sorry, there was a syntax error. Try again

Christoph C. Over a year ago

That´s it! Awesome!! Thank you very much! Just one thing I do not understand. Right now my form has just one input! If my form gets about 20 inputs I have to declare every like you did? So for example: "UPDATE user SET firstname_parent='".$update_firstname_parent."', lastname_parent = '".$update_lastname_parent."', street_parent = '".$update_street_parent."' and so on? Am I right?

ustmaestro Over a year ago

w3schools.com/php/php_mysql_update.asp UPDATE table_name SET column1=value, column2=value2,... WHERE some_column=some_value

ustmaestro Over a year ago

don't forget to escape strings to avoid injections and check for empty strings

|

099 · Accepted Answer · 2015-08-25 08:13:46Z

0

Isn't your if statement incorrect? You are checking to see if something is changed and then outputting the error rather than the otherway around?

if (mysqli_affected_rows($connect) == 1)
{
    die('Could not update data: ' . mysql_error());
} else {
    echo "Updated data successfully\n";
}

to

if (mysqli_affected_rows($connect) == 0) //<--
{
    die('Could not update data: ' . mysql_error());
} else {
    echo "Updated data successfully\n";
}

answered Aug 25, 2015 at 8:13

099

3331 silver badge15 bronze badges

Comments

Gaurang Joshi · Accepted Answer · 2015-08-25 08:20:26Z

0

your QUERY is wrong.

USE "UPDATE ''user SET firstname_parent='".$update_firstname_parent."' WHERE email = '".$_SESSION['email']."'";

edited Aug 25, 2015 at 8:20

answered Aug 25, 2015 at 8:16

Gaurang Joshi

69316 silver badges32 bronze badges

Comments

DirtyBit · Accepted Answer · 2015-08-25 08:22:34Z

There was syntax error in your UPDATE and a missing session_start(); in the update.php file. This should work just fine.

update.php

<?php
session_start();
// Create connection credentials
$db_host = 'localhost';
$db_name = 'DBNAME';
$db_user = 'DBUSER';
$db_pass = 'DBPASS';

// Create mysqli object
$connect = new mysqli ($db_host, $db_user, $db_pass, $db_name);

// Error Handler
if ($connect->connect_error) {
    printf ("Connection failed: %s\n", $connect->connect_error);
    exit();
}   

// Check if form is submitted
if (isset ($_POST['update'])) {
    $update_firstname_parent = mysqli_real_escape_string ($connect, $_POST['firstname_parent'] );
}


$sql = mysqli_query ($connect, "UPDATE `user` SET 
     firstname_parent='".$update_firstname_parent."'  WHERE email = '".$_SESSION['email']."'");

if (mysqli_affected_rows($connect) == 1)
{
  die('Could not update data: ' . mysql_error());
} else {
echo "Updated data successfully\n";
}
mysql_close($connect); 

?>


<?php 
session_start();

if(empty($_SESSION)) // if the session not yet started
   session_start();

if(!isset($_SESSION['email'])) { //if not yet logged in
   header("Location: login.php");// send to login page
   exit;
}

include ('header.php');

$get = "SELECT * FROM user email WHERE email='".$_SESSION['email']."'";
 $result_get = mysqli_query($connect, $get);
 $_SESSION['data'] = mysqli_fetch_assoc($result_get);

?>
    <form method="POST" action="update_profile.php" class="form-horizontal form-label-left">

    <div class="form-group">
    <label class="control-label col-md-3 col-sm-3 col-xs-12">Vorname:</label>
    <div class="col-md-9 col-sm-9 col-xs-12">
    <input type="text" name="firstname_parent" class="form-control" value="<?php echo $_SESSION['data']['firstname_parent']; ?>">
    </div>
    </div>
    <button type="submit" name="update" value="update" class="btn btn-warning btn-lg btn-block">PROFIL VERVOLLSTÄNDIGEN</button>
   </form>

kim de castro · Accepted Answer · 2015-08-26 08:13:24Z

0

First thing to know if the data is correct try to echo

echo($connect, "UPDATE `user` SET 
     firstname_parent='".$update_firstname_parent."'  WHERE email = '".$_SESSION['email']."'";

if the data shows then your code is correct but here's mine:

$sql = mysqli_query("UPDATE user SET firstname_parent='".$update_firstname_parent."'  WHERE email = '".$_SESSION['email']."'");

answered Aug 26, 2015 at 8:13

kim de castro

2996 silver badges19 bronze badges

Collectives™ on Stack Overflow

Update MySQL entry through PHP form

5 Answers 5

6 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

6 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related