Javascript query string not working on mobile

Question

<script>// <![CDATA[
$(function(){
  var currentPostUrl = window.location.href + "?ref=blogshare"
  var currentPostTitle = $('.post-title').text().trim();

  $('#myModal').appendTo("body") 

  var facebookShareUrl = "https://www.facebook.com/sharer/sharer.php?u=" + currentPostUrl
  var emailShareUrl = "mailto:?to=&body=Hey, I thought you might like this post. It's called " + currentPostTitle + ". You can read it here:  " + currentPostUrl + "&subject=Thought you might like this post..."


  $('.email-share').attr('href', emailShareUrl);

// ]]></script>

The goal of the above script is to get the current url and append a ref query string to it. Then we change the href of a link to add a custom mailto.

The above seems to work perfectly fine on desktop. But on mobile (chrome iphone), when I click the email-share link, the ?ref=blogshare is not being appended to the link.

Any ideas why?

You need use encodeURIComponent...

epascarello
– epascarello

2015-09-18 00:45:36 +00:00
Commented Sep 18, 2015 at 0:45 — epascarello
– epascarello, Commented Sep 18, 2015 at 0:45
That was it, thanks!

Jackson Cunningham
– Jackson Cunningham

2015-09-18 00:56:36 +00:00
Commented Sep 18, 2015 at 0:56 — Jackson Cunningham
– Jackson Cunningham, Commented Sep 18, 2015 at 0:56

epascarello · Accepted Answer · 2015-09-18 01:01:32Z

1

You need to encode querystring values.

encodeURIComponent()

var currentPostUrl = encodeURIComponent(window.location.href + "?ref=blogshare");

answered Sep 18, 2015 at 1:01

epascarello

208k20 gold badges206 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript query string not working on mobile

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related