Constructer function's method not working

Question

I have written the following code

<!DOCTYPE html>
<html>
<body>
    <h1 id="para"></h1>
    <script>                
        function Dice(sides) {  
            this.sides = sides; 
            this.roll = function() {                                            
                var randomNumber = Math.floor(Math.random() * this.sides) + 1;
                console.log(randomNumber);
            }                       
        }

        var dice = new Dice(6);
        var dice10 = new Dice(10);
    </script>
</body>
</html>

When I check the console, it's not printing random numbers & it seems my 'roll' method is not working. If I write code without roll method, it's working. But I want to enhance my skills in JS, so I am curious to know what's the problem with roll method in my constructor function.

Side note: "Dice" is plural. A single one of them is called a "die". — T.J. Crowder
– T.J. Crowder, Commented Sep 27, 2015 at 13:49

T.J. Crowder · Accepted Answer · 2015-09-27 13:49:18Z

4

You need to call your roll function:

var dice = new Dice(6);
dice.roll();

answered Sep 27, 2015 at 13:49

community wiki

T.J. Crowder

Sign up to request clarification or add additional context in comments.

Comments

BlitZ · Accepted Answer · 2015-09-27 13:49:15Z

1

Try to call method of object after instantiation:

dice.roll();
dice10.roll();

You does not see roll()s result after call of constructor, because constructor defines method, not calls it (in your case).

answered Sep 27, 2015 at 13:49

community wiki

BlitZ

Comments

MASL · Accepted Answer · 2015-09-27 13:52:17Z

0

Add line

dice.roll();

or

dice10.roll();

at the end.

The problem is you defined the constructor, but didn't call roll.

answered Sep 27, 2015 at 13:52

MASL

9391 gold badge13 silver badges25 bronze badges

Collectives™ on Stack Overflow

Constructer function's method not working

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related