Displaying values contained in an array

Question

I would like to display a message indicating if an input value is present in my rollValue array.

My code does't correctly identify such numbers. This search method is what I have attempted, but why doesn't it display the correct message?

public void search(int value)
{
    for (int i = 0; i < rollValue.length; i++)
    {
        if (rollValue[i] == value)
        {        
            System.out.println(value + " was found");
        }            
        else
        {
            System.out.println(value + " was not found");
        }
        break;
    }
}

Elliott Frisch · Accepted Answer · 2015-10-23 06:37:52Z

You need to iterate (potentially) every value, before you can decide if it was found. Make two methods. Something like

private boolean hasValue(int value) {
    for (int roll : rollValue) {
        if (value == roll) {
            return true;
        }
    }
    return false;
}

Then you can implement search by calling hasValue like

public void search(int value)
{
    if (hasValue(value)) 
    {        
        System.out.println(value + " was found");
    }
    else
    {
        System.out.println(value + " was not found");
    }
}

or as a one line ternary like

System.out.println(value + (hasValue(value) ? " was found" : " was not found"));

or you could add a short-circuit return in search and do something like

public void search(int value) {
    for (int roll : rollValue) {
        if (roll == value) {
            System.out.printf("%d was found%n", value);
            return;
        }
    }
    System.out.printf("%d was not found%n", value);
}

Juned Ahsan · Accepted Answer · 2015-10-23 04:35:17Z

2

Your for loop is breaking after the first iteration. Move break inside the if used to find the value, maybe like this:

for (int i = 0; i < rollValue.length; i++)
        {
            if (rollValue[i] == value)
            {        
                System.out.println(value + " was found");
               break;

            }

            else
            {
                System.out.println(value + " was not found");
            }
        }

Also you may not need to print the "was not found" string all the time so take it away.

answered Oct 23, 2015 at 4:35

Juned Ahsan

68.9k12 gold badges101 silver badges138 bronze badges

4 Comments

Max Lawrence Over a year ago

This is what's happening with that code. 3 was found 2 was not found 2 was not found 2 was not found 2 was not found 2 was found

Juned Ahsan Over a year ago

@MaxLawrence I knew this question is coming ;-) Just use a boolean flag with default value false. If item found, set the flag before breaking the loop. Outside loop, check flag and print accordingly.

Max Lawrence Over a year ago

Would the boolean be inside the for loop?

Juned Ahsan Over a year ago

@MaxLawrence If i tell u everything you wouldn't be able to learn. So give it logical tries. More you struggle, longer will u remember stuff .Good luck!

Collectives™ on Stack Overflow

Displaying values contained in an array

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related