Can't access TextView from another method

Question

I have a TextView block defined in a layout.

<TextView xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/article"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:padding="16dp"
android:textSize="18sp" />

I define private attribute of a class as:

View inflatedView;

Later, in onCreateView method, it's given the value of:

inflatedView = inflater.inflate(R.layout.article_view, container, false);

When accessing the TextView field from the onCreateView method, it makes no problem, however, trying to access it from other methods, returns null reference.

Here's the code I'm using:

TextView article = (TextView) inflatedView.findViewById(R.id.article);

I managed to get it to work by setting the article as private attribute, initializing it's value in onCreateView method, then using it in all other methods, however, I can't understand what's the problem with the approach above.

EDIT:

View inflatedView;
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState) {
    if (savedInstanceState != null) {
        mCurrentPosition = savedInstanceState.getInt(ARG_POSITION);
    }
    //article_view contains the article TextView
    inflatedView = inflater.inflate(R.layout.article_view, container, false);
    return inflatedView;
}

public void updateArticleView(int position) {
    TextView article = (TextView) inflatedView.findViewById(R.id.article);
    article.setText(Ipsum.Articles[position]);
    mCurrentPosition = position;
}

can you provide full code implementation of the first approach? — Ahmad Hammoud
– Ahmad Hammoud, Commented Oct 23, 2015 at 22:57
If the TextView is the root element in the layout, you don't need to call findViewById(...) - the call to inflate(...) will return the TextView directly. — adelphus
– adelphus, Commented Oct 23, 2015 at 23:03
and from where were you calling the updateArticleView() function? — Ahmad Hammoud
– Ahmad Hammoud, Commented Oct 23, 2015 at 23:10
@adelphus Can you explain it more thoroughly? What do I call inflate on? — hazeiio
– hazeiio, Commented Oct 23, 2015 at 23:13
@hazeiio in your code, you are already calling inflate() - just cast the resulting inflatedView variable to a TextView — adelphus
– adelphus, Commented Oct 23, 2015 at 23:16

hazeiio · Accepted Answer · 2015-10-23 23:41:25Z

1

So I solved the problem, by putting the TextView block inside the LinearLayout, and then calling the findViewById(R.id.article);

Managed to get the TextView both by using:

inflatedView.findViewById(R.id.article);

and

getView().findViewById(R.id.article);

answered Oct 23, 2015 at 23:41

hazeiio

1956 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ahmad Hammoud · Accepted Answer · 2015-10-23 23:17:02Z

0

Make sure that inflatedView is not null before using this method.

answered Oct 23, 2015 at 23:17

Ahmad Hammoud

7011 gold badge5 silver badges15 bronze badges

2 Comments

hazeiio Over a year ago

I checked it, the ".setText()" function is never called if it's null.

Ahmad Hammoud Over a year ago

because it will cause an exception.

Collectives™ on Stack Overflow

Can't access TextView from another method

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related