Problems with my Javascript image preloader code

Question

I can't seem to understand why my images still won't show up with my code. All my folders and images are correctly names and placed accordingly. However, if someone could look over my code and see if there is an error there and get this code to run properly. It would be great.

    <!DOCTYPE html>
<html>
    <head>
        <title>Sample page</title>   
        <script type="text/javascript">

function changeImage(replacement)
        {
            document.getElementById("main_image").src = replacement;
            return false;   
        }

//  End -->
</script>
</head>






<body>

<p>
<a href="javascript:changeImage('image1.jpg')">Image 1</a>
<a href="javascript:changeImage('image2.jpg')">Image 2</a>
<a href="javascript:changeImage('image3.jpg')">Image 3</a>
<a href="javascript:changeImage('image4.jpg')">Image 4</a>
</p>
<p>
<img id="main_image" src="image-viewer/blank.jpg" alt="" /></p>


<p><center>
<font face="arial, helvetica" size"-2">
</center><p>



</font></body>
</html>

Well, could you please describe the soution that helped you. Or delete the post if it's not so interesting in order to keep stackowerflow flood-free. Thank you — Dan
– Dan, Commented Dec 15, 2010 at 20:33

SLaks · Accepted Answer · 2010-08-03 05:26:50Z

2

Remove the return false; line.
(This should only be used for onclick handlers)

When you return any value from a javascript: URI, the browser navigates to the return value.
When you return false from an event handler, the event is suppressed.

answered Aug 3, 2010 at 5:26

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Toby · Accepted Answer · 2010-08-03 05:26:00Z

0

It's hard to tell without an example page. If all your images are under the 'image-viewer' directory then you will need to add that to the path in all your links i.e

<a href="javascript:changeImage('image-viewer/image1.jpg')">Image 1</a>

answered Aug 3, 2010 at 5:26

Toby

1,66012 silver badges8 bronze badges

Comments

Jordan S. Jones · Accepted Answer · 2010-08-03 05:26:28Z

0

Is image1.jpg, image2.jpg, image3.jpg, and image4.jpg in the same folder as the file you pasted? If not, you need to specify the path to that in your javascript:changeImage() call.

answered Aug 3, 2010 at 5:26

Jordan S. Jones

13.9k5 gold badges47 silver badges50 bronze badges

Collectives™ on Stack Overflow

Problems with my Javascript image preloader code

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related