Convert JSON string to hash

Question

I have a Ruby on Rails JSON question.

I have what I think is a strange error. I have the following JSON string which I get like this from an external API

test = "[{'domain': 'abc.com'}, {'domain': 'def.com'}, {'domain': 'ghi.com'}]"

Now, I want to convert this string to a hash using:

hash = JSON.parse test

The problem is that it errors with:

JSON::ParserError: 419: unexpected token at '{'domain': 'abc.com'}, {'domain': 'def.com'}, {'domain': 'ghi.com'}]'

The problem now with just replacing ' with " is dangerous if any strings includes ' or ". Anyone have a solution?

You could do JSON.parse test.gsub("'", '"'). This will remove all the single quotes, and then parse the string — Santhosh
– Santhosh, Commented Jan 12, 2016 at 5:39
I get this JSON from an external API so your solution is probably the best way. Thanks! — JayC
– JayC, Commented Jan 12, 2016 at 5:47
However, there might be a problem if there is a ' or '"' in the json values, replacing all ' to " can break the json.... anyone have a solution? — JayC
– JayC, Commented Jan 12, 2016 at 5:50

Community · Accepted Answer · 2017-05-23 11:51:59Z

13

It's most likely because this isn't valid JSON. Change your single quotes to double quotes, like so:

test = '[{"domain": "abc.com"}, {"domain": "def.com"}, {"domain": "ghi.com"}]'

An explanation can be found here, and you can validate your JSON here.

edited May 23, 2017 at 11:51

CommunityBot

11 silver badge

answered Jan 12, 2016 at 5:39

MyCah

4183 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

JayC Over a year ago

The problem is that I am getting it like this from an external API. Is there a safe way to "convert" it to real JSON? Just replacing the 'is dangerous.

Jordan Running Over a year ago

You're correct about "just replacing the '" being dangerous. There isn't a great way to do it, unfortunately. I strongly suggest emailing the API provider (or filing an issue if they have some such system set up) and telling them that their API is incompatible with all strict JSON parsers (which is likely to include Ruby, Java, Python, PHP, .NET—just about everything except calling eval in a JavaScript runtime, a risk no sane developer will want to take).

JayC Over a year ago

I solved it (ugly fix which should be pretty safe) with

JSON.parse test.gsub("{'", '{"').gsub("':'", '":"').gsub("' : '", '":"').gsub("' :'", '":"').gsub("': '", '":"').gsub("'}", '"}').gsub("':", '":').gsub(", '", ',"').gsub(",'", ',"').gsub("' ,", '",').gsub("',", '",').gsub("u'", '"').gsub("']", '"]').gsub("['", '["')

MyCah Over a year ago

That is ugly, and honestly shouldn't be used as a production solution. I agree with Jordan: speak to whoever provides the API. It's their responsibility to create something their users can consume (which it currently is not doing). Is this a commercial API?

Peter Tadros · Accepted Answer · 2020-09-15 13:18:35Z

7

Using Rails 4 or above, If you want to have symbol keys instead of string keys, you can use deep_symbolize_keys method

hash = JSON.parse(test).deep_symbolize_keys

That's in addition that the real problem was invalid json as MyCah mentioned.

answered Sep 15, 2020 at 13:18

Peter Tadros

9,4353 gold badges38 silver badges32 bronze badges

Comments

Jordan Running · Accepted Answer · 2016-01-12 05:37:51Z

6

You're getting an error because your string isn't valid JSON. In JSON all property names must be double-quoted and string values must also be double-quotes. Single-quotes are never valid.

test = '[{"domain": "abc.com"}, {"domain": "def.com"}, {"domain": "ghi.com"}]'
JSON.parse(test)
# => [ { "domain" => "abc.com" },
#      { "domain" => "def.com" },
#      { "domain" => "ghi.com" } ]

answered Jan 12, 2016 at 5:37

Jordan Running

107k18 gold badges193 silver badges189 bronze badges

Comments

wasipeer · Accepted Answer · 2016-01-12 05:36:38Z

0

Use this piece of code. you are missing ActiveSupport::JSON

  ActiveSupport::JSON.decode json_string

answered Jan 12, 2016 at 5:36

wasipeer

1,03311 silver badges23 bronze badges

1 Comment

JayC Over a year ago

Tried: hash = ActiveSupport::JSON.decode test. Same error, sorry.

Collectives™ on Stack Overflow

Convert JSON string to hash

4 Answers 4

4 Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related