Stop Execution utill all threads created in a for loop are terminated C#

Question

I am saving some csv files using threads, Threads are created in a loop Here is the code

foreach (var f in Files)
{

   string tFile = f.ToString(); 
   Thread myThread = new Thread(() =>  SaveCSVFile(BulkExtractFolder, tFile));
   myThread.Start();
}

//save folder as zip file and download it

it starts saving csv files but when the zip file downloads it does not contain all files in it, because some threads are in execution when I zip this folder, How I can know that all threads started in for loop have completed their execution.

By not using threads, but tasks and ContinueWith. See C# Waiting for multiple threads to finish, Running multiple async tasks and waiting for them all to complete. — CodeCaster
– CodeCaster, Commented Jan 15, 2016 at 13:01

Community · Accepted Answer · 2017-05-23 11:59:17Z

1

This looks like a job for Parallel.ForEach https://msdn.microsoft.com/en-us/library/dd460720(v=vs.110).aspx

Parallel.ForEach(Files, (f)=> {
   string tFile = f.ToString(); 
   SaveCSVFile(BulkExtractFolder, tFile);
});

And here is how you limit the number of threads: How can I limit Parallel.ForEach?

Edit: For older versions of .NET, this will work:

var numFiles = Files.Count; //or Files.Length, depending on what Files is
var threads = new Thread[numFiles];
for(int i = 0; i < numFiles; i++)
{
    threads[i] = new Thread(() =>  SaveCSVFile(BulkExtractFolder, Files[i]));
    threads[i].Start();
}
for(int i = 0; i < numFiles; i++)
{
    threads[i].Join();
}

edited May 23, 2017 at 11:59

CommunityBot

11 silver badge

answered Jan 15, 2016 at 13:04

Alex

14.7k5 gold badges45 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

AddyProg Over a year ago

The application I am working on is in MVC2 with Dot Net 3.5

Rahul · Accepted Answer · 2016-01-15 13:04:11Z

0

If you are zipping/downloading the files in main thread then you can join all your child threads using Thread.Join() method. In which case, main thread will wait until all other threads have completed.

foreach (var f in Files)
{
   string tFile = f.ToString(); 
   Thread myThread = new Thread(() =>  SaveCSVFile(BulkExtractFolder, tFile));
   myThread.Start();
   myThread.Join();
}

answered Jan 15, 2016 at 13:04

Rahul

78.1k14 gold badges80 silver badges132 bronze badges

1 Comment

Servy Over a year ago

If you're going to wait immediately after starting the thread you might as well just do all of the work in the current thread.

daryal · Accepted Answer · 2016-01-15 13:09:17Z

0

If you are using .Net 4 or higher, you may use Task instead of Thread and WaitAll method.

List<Task> tasks = new List<Task>();
foreach (var f in Files)
{
   string tFile = f.ToString(); 
   tasks.add(Task.Factory.StartNew(() =>
        {               
             SaveCSVFile(BulkExtractFolder, tFile)
        });
   );
}

Task.WaitAll(tasks.toArray());

edited Jan 15, 2016 at 13:09

answered Jan 15, 2016 at 13:03

daryal

15k4 gold badges40 silver badges54 bronze badges

1 Comment

AddyProg Over a year ago

The application I am working on is in MVC2 with Dot Net 3.5

Collectives™ on Stack Overflow

Stop Execution utill all threads created in a for loop are terminated C#

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related