Why does this code cause a ConcurrentModificationException in Java?

Question

public class MainMenuState {
    protected void init() {
        this.addElements(
             new GUIElement()
             .addMousePressed((e, element) -> {
                   this.elements.add(new GUIElement()
                   .addMouseEntered((e, element) -> //...)
             }
        )
   );
}

addElements is defined as:

void addElements(GameElement... elements){
    this.elements.addAll(Arrays.asList(elements));
}

I expect the code to create another GUIElement and add it to list elements when I click the enclosing GUIElement. Instead, when it is clicked, a ConcurrentModificationException is thrown. I understand that ConcurrentModificationException is thrown when a list is modified while elements are being added to it, but mouseEntered isn't called until after elements has been modified.

So how is this error occurring?

The error text:

Exception in thread "Thread-2" java.util.ConcurrentModificationException
at java.util.LinkedList$ListItr.checkForComodification(Unknown Source)
at java.util.LinkedList$ListItr.next(Unknown Source)
at java.lang.Iterable.forEach(Unknown Source)
at code.state.GameState.render(GameState.java:34)
at code.state.Handler.render(Handler.java:32)
at code.state.Handler.render(Handler.java:28)
at code.frame.GameEngine.render(GameEngine.java:94)
at code.frame.GameEngine.run(GameEngine.java:68)
at java.lang.Thread.run(Unknown Source)

Ulises · Accepted Answer · 2016-02-01 02:42:33Z

5

I don't think there's enough context here to pinpoint exactly the cause of your issue. But one solution would be simply to use:

 List<Object> objList = Collections.synchronizedList(new ArrayList<Object>());

to instantiate the problematic list to simple synchronize access to it.

answered Feb 1, 2016 at 2:42

Ulises

9,7053 gold badges32 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Austin · Accepted Answer · 2016-02-01 02:50:39Z

4

I'm assuming you're rendering something to screen in the code.frame.GameEngine.render() method. The problem is you're using a LinkedList which is not thread-safe. Thus, it's possible to add a new GUIElement to elements while code.frame.GameEngine.render() method is iterating over elements (this happens asynchronously). You need to use a thread-safe collection like:

List<GUIElement> elements = Collections.synchronizedList(new LinkedList<GUIElement>());

answered Feb 1, 2016 at 2:50

Austin

8,6553 gold badges34 silver badges40 bronze badges

Collectives™ on Stack Overflow

Why does this code cause a ConcurrentModificationException in Java?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related