"Not all code paths return a value" when returning View in MVC

Question

I want to return a view if an object(country) is not null. But I get the error "Not All code paths return a value"

My code looks like this

public ActionResult Show(int id)
{
    if (id != null)
    {
        var CountryId = new SqlParameter("@CountryId", id);
        Country country = MyRepository.Get<Country>("Select * from country where CountryId=@CountryId", CountryId);
        if (country != null)
        {
            return View(country);
        }
    }

}

Tim · Accepted Answer · 2016-04-28 00:12:39Z

5

This happens when you are returning something from within the "if" statement. The compiler thinks, what if the "if" condition is false? That way you are not returning anything even when you have the return type of "ActionResult" defined in the function. So add some default returns in the else statement:

public ActionResult Show(int id)
{

    if (id != null)
    {
        var CountryId = new SqlParameter("@CountryId", id);
        Country country = MyRepository.Get<Country>("Select * from country where CountryId=@CountryId", CountryId);

        if (country != null)
        {
            return View(country);
        }
        else
        {
            return View(something);
        }
    }
    else
    {
        return View(something);
    }
}

edited Apr 28, 2016 at 0:12

Tim

28.6k8 gold badges65 silver badges80 bronze badges

answered Apr 24, 2016 at 15:13

Captain Red

1,1712 gold badges16 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

"Not all code paths return a value" when returning View in MVC

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related