How to map resources of two devices in one Linux kernel driver using device tree?

Question

I am writing a Linux kernel driver for a watchdog using the CPU’s internal registers and a dedicated location in (persistent) RAM for storing debug information in case of a watchdog-triggered reset.

In the old world, I had two resources of type IORESOURCE_MEM in my board file: the internal registers (base address of internal regs plus offset) and the location in RAM (absolute memory address).

I could access these via platform_get_resource() with the appropriate index, and then I could remap.

In the new world featuring a device tree, my node for the watchdog is located in the domain of internal CPU registers and I can access them without problems.

But how do I add my memory location in RAM? The base address of RAM is different from the CPU-internal registers, so I can’t just add another range to the “reg” entry (like reg = <0x20300 0x408>, <0x3BFFE000 0x1000>;). Do I need to add a new “device” like this, maybe?

PRAM {
    #address-cells = <1>;
    #size-cells = <1>;       
    PRAM0: Watchdog_Crash_Debug_Context {            
        reg = <0x3BFFE000 0x1000>;
    };
};

But how do I reference it in the watchdog device driver? Or in the watchdog device tree entry?

Linux version is 4.1.18.

hardware of software watchdog?

jgr208
– jgr208

2016-05-03 15:23:01 +00:00
Commented May 3, 2016 at 15:23 — jgr208
– jgr208, Commented May 3, 2016 at 15:23
Hardware watchdog (on Marvell Armada XP)

Hans W. Heckel
– Hans W. Heckel

2016-05-07 07:44:27 +00:00
Commented May 7, 2016 at 7:44 — Hans W. Heckel
– Hans W. Heckel, Commented May 7, 2016 at 7:44

Hans W. Heckel · Accepted Answer · 2016-05-24 08:17:12Z

1

In the meantime I have found the solution myself. The secret was the magic function of_parse_phandle().

Device Tree setup:

soc {
    ...
    internal-regs {
        ...
        watchdog_global {
            ...
            PRAM_address = <&PRAM0>;
        };
    };
};


PRAM {
    #address-cells = <1>;
    #size-cells = <1>;
    ranges = <0 0 0x3b000000 0x5000000>;

    PRAM0: Watchdog_Crash_Debug_Context {            
        reg = <0xFFE000 0x1000>;
    };
};

Usage in code (really simple!):

struct device_node *PRAM_node = of_parse_phandle(pdev->dev.of_node, "PRAM_address", 0);
debug_info = of_iomap(PRAM_node, 0);
of_node_put(PRAM_node);

where pdev->dev.of_node refers to device tree node watchdog_global and debug_info is a pointer to a self-defined struct.

answered May 24, 2016 at 8:17

Hans W. Heckel

217 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to map resources of two devices in one Linux kernel driver using device tree?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related