ASP.NET MVC3 send email using SMTP

Question

I've implemented a code that should allow me to send email to gmail from my web application and I can't figure out what is wrong with it...

When I press the "Submit" button nothing happens, there are no errors. I also added breakpoints in my controller but they are not fired...

Here is my code:

Model:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.Security;
using System.ComponentModel.DataAnnotations;

namespace TripPlanner.Models
{
    public class EmailFormModel
    {
        [Required]
        [StringLength(20, MinimumLength = 5)]
        public string Name { get; set; }
        [Required]
        [DataType(DataType.EmailAddress)]
        public string Email { get; set; }
        [Required]
        public string Subject { get; set; }
        [Required]
        public string Message { get; set; }
    }
}

View:

<%@ Page Language="C#" MasterPageFile="~/Views/Shared/Site.Master" Inherits="System.Web.Mvc.ViewPage<TripPlanner.Models.EmailFormModel>" %>
<% using (Html.BeginForm()) {%>
    <form method="post">
        <%: Html.ValidationSummary("Please correct the errors and try again.") %>
        <p>Name: </p>
        <%: Html.TextBoxFor(m => m.Name)%>
        <p>Email: </p>
        <%: Html.TextBoxFor(m => m.Email)%>
        <p>Subject: </p>
        <%: Html.TextBoxFor(m => m.Subject)%>
        <p>Message: </p>
        <%: Html.TextBoxFor(m => m.Message)%>
        <input type ="submit" value ="Send" />
    </form>
<% } %>

Controller:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Net.Mail;
using System.Web.Mvc;
using System.IO;
using System.Net;
using TripPlanner.Models;

namespace TripPlanner.Controllers
{
    public class SendMailerController: Controller
    {
        [HttpGet]
        public ActionResult Index()
        {
            return View();
        }
        [HttpPost]
        public ActionResult Index(EmailFormModel vm)
        {
            if(ModelState.IsValid)
            {
                try
                {
                    MailMessage msz = new MailMessage();
                    msz.From = new MailAddress(vm.Email);//Email which you are getting from contact us page 
                    msz.To.Add("[email protected]");//Where mail will be sent 
                    msz.Subject = vm.Subject;
                    msz.Body = vm.Message;
                    SmtpClient smtp = new SmtpClient();

                    smtp.Host = "smtp.gmail.com";
                    smtp.Port = 587;
                    smtp.Credentials = new System.Net.NetworkCredential("[email protected]", "my_valid_pass");
                    smtp.EnableSsl = true;
                    smtp.Send(msz);

                    ModelState.Clear();
                }
                catch(Exception ex )
                {
                    ModelState.Clear();
                }              
            }

            return View();
        }
        public ActionResult Error()
        {
            return View();
        }
    }
}

Are you sure there are no exceptions being thrown? You seem to be swallowing the exception in your catch block. — user1666620
– user1666620, Commented May 5, 2016 at 9:03

Banwari Yadav · Accepted Answer · 2016-05-05 10:50:36Z

1

<% using (Html.BeginForm("Index", "SendMailer", FormMethod.Post)) {%>
<form method="post">
    <%: Html.ValidationSummary("Please correct the errors and try again.") %>
    <p>Name: </p>
    <%: Html.TextBoxFor(m => m.Name)%>
    <p>Email: </p>
    <%: Html.TextBoxFor(m => m.Email)%>
    <p>Subject: </p>
    <%: Html.TextBoxFor(m => m.Subject)%>
    <p>Message: </p>
    <%: Html.TextBoxFor(m => m.Message)%>
    <input type ="submit" value ="Send" />
</form>

Please change your begin form syntax, you need to specify the action and controller name on which you want to post form data.

answered May 5, 2016 at 10:50

Banwari Yadav

5061 gold badge3 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user1666620 · Accepted Answer · 2016-05-05 09:22:42Z

0

At least one of your problems is that you need to tell the SMTP client to not use your windows credentials before you provide the username and password of the gmail account.

Add

smtp.UseDefaultCredentials = false;

above this line of code (NOT after).

smtp.Credentials = new System.Net.NetworkCredential("[email protected]", "my_valid_pass");

The other obvious problem is that you really need to do something useful in your catch block - right now you are actively sabotaging your efforts by swallowing the exception.

You need to log the exception, or at the very least throw it. Removing the try/catch altogether would also be better than what you are doing right now.

Also, gmail will ignore whatever value you place in MailMessage.From property as it does not allow you to send emails as other users.

edited May 5, 2016 at 9:22

answered May 5, 2016 at 9:05

user1666620

4,81821 silver badges28 bronze badges

6 Comments

Valip Over a year ago

I added smtp.UseDefaultCredentials = false; and still nothing happens...Also removed the catch block and there are no errors.

user1666620 Over a year ago

@PavelValeriu When you set breakpoints and debug through your code, what happens? Is the ModelState.IsValid property true or false?

Valip Over a year ago

The problem is that the breakpoints from controller are not hit.

user1666620 Over a year ago

@PavelValeriu are you building in debug or release mode?

Valip Over a year ago

I am building in debug mode

|

Collectives™ on Stack Overflow

ASP.NET MVC3 send email using SMTP

2 Answers 2

Comments

6 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related