How to serialize C# objects to generate specific JSON

Question

I am trying to create JSON like the following to pass to an external via TCP.

{"method": "dither", "params": [10, false, {"pixels": 1.5, "time": 8, "timeout": 40}], "id": 42}

I came close, but this is what I got instead:

{"method": "dither", "params": [10, false,"{"pixels": 1.5, "time": 8, "timeout": 40}"], "id": 42}

Notice the quote marks around the 3rd element of the params array.

I would appreciate any help in resolving this. Here is my code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Runtime.Serialization;
using System.Runtime.Serialization.Json;
using System.IO;
using System.Collections;
using System.Xml;
using System.Reflection;

namespace DitherTest
{
    [CollectionDataContract]
    public class DitherParametersList : ArrayList
    {
        public DitherParametersList() : base()
        {}
    }

    [DataContract]
    public class Dither
    {
        [DataMember( Name="method", Order=1)]
        public string Method { get; set; }

        [DataMember( Name="params", Order=2)]
        public DitherParametersList Parameters { get; set; }

        [DataMember( Name="id", Order=3)]
        public int Id { get; set; }
    }

    [DataContract( Namespace="")]
    public class Settle
    {
        [DataMember( Name = "pixels" )]
        public double Pixels { get; set; }
        [DataMember( Name = "time" )]
        public int Time { get; set; }
        [DataMember( Name = "timeout" )]
        public int Timeout { get; set; }

        public string SerializeJson()
        {
            return this.ToJSON();
        }
    }

    static class Extensions
    {
        public static string ToJSON<T>( this T obj ) where T : class
        {
            DataContractJsonSerializer serializer = new DataContractJsonSerializer( typeof( T ) );
            using ( MemoryStream stream = new MemoryStream() )
            {
                serializer.WriteObject( stream, obj );
                return Encoding.Default.GetString( stream.ToArray() );
            }
        }
    }

    class Program
    {
        static void Main( string[] args )
        {
            double ditherAmount = 10.0;
            bool ditherRaOnly = false;

            Settle settle = new Settle { Pixels = 1.5, Time = 8, Timeout = 40 };
            DitherParametersList parameterList = new DitherParametersList();
            parameterList.Add( ditherAmount );
            parameterList.Add( ditherRaOnly );
            string settleStr = settle.SerializeJson();
            parameterList.Add( settleStr );

            Dither dither = new Dither { Method = "dither", Parameters = parameterList, Id=42 };

            string temp = dither.ToJSON();


        }
    }
}

Thanks in advance

To generate C# classes based on JSON format, you can use - json2csharp.com — Sanket
– Sanket, Commented Jun 9, 2016 at 17:23
first and foremost - use json.net for json in c#. Thats what MS uses in most places now — pm100
– pm100, Commented Jun 9, 2016 at 17:24
Try this: newtonsoft.com/json, ditch DataContractJsonSerializer — Rosdi Kasim
– Rosdi Kasim, Commented Jun 9, 2016 at 17:47

pm100 · Accepted Answer · 2016-06-09 17:32:55Z

1

you told it to make the third arg a string. You serialized it to a string then stuck it in as an arg.

you need

parameterList.Add( settle );

answered Jun 9, 2016 at 17:32

pm100

50.6k25 gold badges95 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Rosdi Kasim Over a year ago

He wants it to be a string. Check his question. I suspect a bug in the deserializer he is using.

pm100 Over a year ago

my reading is that he wants it like the first line in the question

user2102194 Over a year ago

No, I don't think that I want it to be a string. That is probably why the quotes are there.

Rosdi Kasim Over a year ago

After 're-rereading' the question, you are probably correct. Let him clarify his question.

Rosdi Kasim Over a year ago

Lol then WTH did you do this? string settleStr = settle.SerializeJson(); ?? Just add settle straight away like @pm100 suggested.

|

dagoltz · Accepted Answer · 2016-06-09 18:45:18Z

1

First of all, be sure to use newtonsoft.com/json like pm100 mentioned in his comment. I've changed your code so that it would work with newtonsoft.json and got exactly what you've asked for:

{"method": "dither", "params": [10, false, {"pixels": 1.5, "time": 8, "timeout": 40}], "id": 42}

I removed the DitherParametersList you've created and used those models:

public class Dither
{
    [JsonProperty("method", Order = 1)]
    public string Method { get; set; }

    [JsonProperty("params", Order = 2)]
    public ArrayList Parameters { get; set; }

    [JsonProperty("id", Order = 3)]
    public int Id { get; set; }
}

public class Settle
{
    [JsonProperty("pixels")]
    public double Pixels { get; set; }

    [JsonProperty("time")]
    public int Time { get; set; }

    [JsonProperty("timeout")]
    public int Timeout { get; set; }
}

And serialized them easily:

class Program
{
    static void Main(string[] args)
    {
        var settle = new Settle { Pixels = 1.5, Time = 8, Timeout = 40 };
        var parameterList = new ArrayList { 10, false, settle };
        var dither = new Dither { Method = "dither", Parameters = parameterList, Id = 42 };

        string temp = JsonConvert.SerializeObject(dither);
    }
}

answered Jun 9, 2016 at 18:45

dagoltz

727 bronze badges

3 Comments

user2102194 Over a year ago

So what I need cannot be done with the MS serializer?

dagoltz Over a year ago

as will-ray stated, you can trim the quotes: string settleStr = settle.SerializeJson().Trim('"'); But it's definitely not the right way to go.

dagoltz Over a year ago

Sure, feel free to choose my answer as the solution.

Will Ray · Accepted Answer · 2016-06-10 01:56:26Z

0

The quotes are coming from the first serialization that you did here:

string settleStr = settle.SerializeJson();

Assuming that you want to avoid using the Newtonsoft library, an immediate fix would be to simply trim them off:

string settleStr = settle.SerializeJson().Trim('"');

A more robust solution would only require serialization one time. If you used a List{string} instead of a DitherParamtersList, you could do this:

Settle settle = new Settle { Pixels = 1.5, Time = 8, Timeout = 40 };
var parameterList = new List<string>()
{
    ditherAmount.ToString(),
    ditherRaOnly.ToString(),
    string.Join(",", settle.Pixels, settle.Time, settle.Timeout)
};

Dither dither = new Dither { Method = "dither", Parameters = parameterList, Id = 42 };

string temp = dither.ToJSON();

edited Jun 10, 2016 at 1:56

answered Jun 10, 2016 at 1:50

Will Ray

11k3 gold badges49 silver badges64 bronze badges

1 Comment

user2102194 Over a year ago

Thanks, I opted for the Newtonsoft library...Problem solved.

Collectives™ on Stack Overflow

How to serialize C# objects to generate specific JSON

3 Answers 3

7 Comments

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related