Best way to check SQLDataReader before reading

Question

I am reading data from DB using SqlDataReader. What is best way to check, before reading data. Which one is best out of 3

Method 1

 using (SqlDataReader objReader = sqlCommand.ExecuteReader())
                    {
                        if (objReader != null)
                        {
                            while (objReader.HasRows && objReader.Read())
                            {
                                //code
                            }
                        }
                    }

Method 2

                using (SqlDataReader objReader = sqlCommand.ExecuteReader())
                    {
                        if (objReader != null)
                        {
                            while (objReader.Read())
                            {
                                //code
                            }
                        }
                    }

Method 3

               using (SqlDataReader objReader = sqlCommand.ExecuteReader())
                    {

                            while (objReader.HasRows && objReader.Read())
                            {
                                //code
                            }

                    }

Best is opinion based. These kind of questions are off-topic on SO. — Tim Schmelter
– Tim Schmelter, Commented Jul 25, 2016 at 14:43
@TimSchmelter Thanks, Just want to know if it is needed to check NULL condition with HasRow — user1926138
– user1926138, Commented Jul 25, 2016 at 14:45

Community · Accepted Answer · 2017-05-23 12:32:55Z

1

Afaik SqlCommand.ExecuteReader never returns null. It can throw various excpetions but it's never null. So this check is redundant.

You also don't need to check if it HasRows in every loop iteration. That information is useful only at the beginning and not every time. But it is not necessary. You won't get any errors if you try to read records when there are none.

So i'd prefer(opinion-based) this:

using (SqlDataReader objReader = sqlCommand.ExecuteReader())
{
    if(objReader.HasRows)
    {
        while (objReader.Read())
        {
            //code
        }
    }
    else
    {
      // output/ log this? 
    }
}

edited May 23, 2017 at 12:32

CommunityBot

11 silver badge

answered Jul 25, 2016 at 14:51

Tim Schmelter

462k79 gold badges720 silver badges981 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Best way to check SQLDataReader before reading

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related