Factory "is not defined" in AngularJS

Question

I'm a beginner in Angular world, and I can't work out why I'm still getting "not defined" error. Here is my code:

angular.module('dopasujApp').factory('getProducts', ['$http', function ($http) {
var dataFactory = {};
dataFactory.sort='ASC';
dataFactory.orderBy='PRODUCT_NAME';
dataFactory.search='a';
dataFactory.filters={};
dataFactory.filters.ATTRIBS=[46,25];
dataFactory.filters.SIZE=[165,40];

getProducts.listProducts = function() {
    var request = $http({
        method: "POST", 
        url: "http://******/backend/internalAPI.php?action=getListing&fit=1&limit=10&vendor=20",
        headers: {
            'Content-Type': 'application/json'
        },
        data: {
            data: dataFactory
        }
    });

    var products = angular.fromJson(request);

    return products;
}

return false;

}]);

And here goes my controller (just for testing purposes now).

angular.module('dopasujApp')
.controller('MainCtrl', ['getProducts', '$scope','$rootScope', 
    function (getProducts, $scope,$rootScope) {
        console.log(getProducts.listProducts())
    }
]);

SergeS · Accepted Answer · 2016-09-09 12:14:16Z

getProducts variable in factory is not defined. The name you used before is just informative name for angular
In your factory you are returning "false" as actual result. So angular treats your "false" as result.

It should look like that :

angular.module('dopasujApp').factory('getProducts', ['$http', function ($http) {
    var dataFactory = {}, getProducts = {};
    dataFactory.sort='ASC';
    dataFactory.orderBy='PRODUCT_NAME';
    dataFactory.search='a';
    dataFactory.filters={};
    dataFactory.filters.ATTRIBS=[46,25];
    dataFactory.filters.SIZE=[165,40];

    getProducts.listProducts = function() {
        return $http({
            method: "POST", 
            url: "http://******/backend/internalAPI.php?action=getListing&fit=1&limit=10&vendor=20",
            headers: {
                'Content-Type': 'application/json'
            },
            data: {
                data: dataFactory
            }
        });
    }

    return getProducts;

}]);

Controller

angular.module('dopasujApp').controller('MainCtrl', ['getProducts', '$scope','$rootScope', 
    function (getProducts, $scope,$rootScope) {
        getProducts.listProducts().then(function(res) {
            console.log(res.data);
        });
    }
]);

EDIT:

Also note, that $http returns promise, but not actual query result, updated my example accordingly

Shakir Ahamed · Accepted Answer · 2016-09-09 12:12:35Z

0

try like this

var yourapp = angular.module('dopasujApp', []);  //your defining your app first
yourapp.factory('getProducts', function ($http)
{
   return {
       //write your factory methods
   };
});

you controller should be like below

yourapp.controller('MainCtrl', function PostController($scope, getProducts, $compile)
{
    //here your controller methods
});

answered Sep 9, 2016 at 12:12

Shakir Ahamed

1,3163 gold badges16 silver badges40 bronze badges

Collectives™ on Stack Overflow

Factory "is not defined" in AngularJS

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related