Trouble in using forEach function in node.js

Question

I have been learning about q promises and tried to build up some mock APIs to implement its functionality,While doing so I came across the following error,

Enterprise.forEach is not a function

My API code is as follows,

var mongoose = require('mongoose');

var Enterprise = mongoose.model('Enterprise_gpy');
var q = require('q');

var displayEnterprise = function(req, res) {

  function displayEnterpriseName() {

    var deferred = q.defer();

    Enterprise.forEach(function(err, doc) {

      if (err) {
        console.log('Error Finding Files');
        deferred.reject(err);
      } else {
        var name = Enterprise.enterprise_name;

        deferred.resolve({
          name: name
        });
      }

      return deferred.promise;
    });
  }

  function displayEnterpriseEmail() {


    var deferred = q.defer();

    Enterprise.forEach(function(err, doc) {

      if (err) {
        console.log('Error Finding Files');
        deferred.reject(err);
      } else {
        var email = Enterprise.enterprise_email;

        deferred.resolve({
          email: email
        });
      }

      return deferred.promise;
    });
  }
  q.all([
      displayEnterpriseName(),
      displayEnterpriseEmail()
    ])
    .then(function(success) {
      console.log(500, success);
    })
    .fail(function(err) {
      console.log(200, err);
    });
}
module.exports = {

  displayEnterprise: displayEnterprise
}

Shaishab Roy · Accepted Answer · 2016-09-23 07:19:10Z

2

In your code Enterprise is a mongoose schema so when you try to do loop using forEach then got

Enterprise.forEach is not a function

you can use forEach after Enterprise.find(). so use

Enterprise.find({}, function(err, docs) {
   if (err) {
    console.log('Error Finding Files');
    deferred.reject(err);
   } else {
     var names = [];
     docs.forEach (function(doc) {
       var name = doc.enterprise_name;
       names.push(name);// pushed in names array
       //.....
     });
     deferred.resolve({
      names: names
    }); // return all names
   }
});

instead of

Enterprise.find().forEach

and should use

var name = doc.enterprise_name; instead of var name = Enterprise.enterprise_name;

and

var email = doc.enterprise_email; instead of var email = Enterprise.enterprise_email;

edited Sep 23, 2016 at 7:19

answered Sep 23, 2016 at 5:40

Shaishab Roy

16.9k7 gold badges56 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

akila arasan Over a year ago

error persists, TypeError: Enterprise.find(...).forEach is not a function

akila arasan Over a year ago

well it works ,but displays only the first document name and email instead of listing the entire documents in the Enterprise collection

Shaishab Roy Over a year ago

your question was problem in forEach so I shown that. however if you want to return all docs name then pushed in an array and return it. see update answer :) @Idlliofrio

nadavvadan · Accepted Answer · 2016-09-23 05:46:26Z

1

forEach only works for arrays, and you're using it on a mongoose model. try this instead:

Enterprise.find().exec(function(err, docs) {
  docs.forEach(function(doc) {
    // do something with all the documents
  }
  // do something outside the loop
})

answered Sep 23, 2016 at 5:46

nadavvadan

4,2001 gold badge20 silver badges29 bronze badges

Collectives™ on Stack Overflow

Trouble in using forEach function in node.js

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related