Can't find syntax error in batch file

Question

So I'm relatively new to coding, and I just can't seem to find the syntax error in this code of mine. Every time the menu loads, and I press 1, it closes and flashes a quick error saying that there is a syantax error. If you guys could help me find out what's causing the problem. BTW, this is a text based rpg. No judge :)

@echo off
TITLE VICTIMQUEST =-= RETRO EDITION
setlocal enabledelayedexpansion

:menu
color 0a
cls
echo.
echo VICTIMQUEST =-= RETRO EDITION
echo.
echo 1) Begin
echo 2) Exit
echo.
set /p c=C:\

if "%c%" == "1" goto new
if "%c%" == "2" exit
goto menu

:new
set health=100
set monsterhealth=30
set playerdmg=7
set monsterdmg=3
goto home

:home
cls
echo You sit in your nice, cozy cabin...
echo ----------------------
echo Nothing you need to worry about.
echo.
echo 1) FIGHT!
echo 2) Quit :|
echo.
set /p c=C:\

if "%c%" == "1" goto encounter1
if "%c%" == "2" goto menu
goto home

:encounter1
cls
echo You: %health%
echo.
echo 1) Attack
echo 2) Run away
echo.
set /p c=C:\

if "!c!" == "1' goto attack1
if "!c!' == "2" goto home
goto encounter1

Please help. Thanks!

1. If you open a Command Prompt window and run your script from there, you'll see the exact error message without the console window disappearing on you. (If you temporarily remove the @echo off line, you should see where the problem is too.) 2. Trying to write non-trivial code as a .bat/.cmd script is asking for pain. Why don't you learn a nice scripting language like Python instead? — jamesdlin
– jamesdlin, Commented Sep 27, 2016 at 23:29

FloatingKiwi · Accepted Answer · 2016-09-27 23:30:44Z

3

3 Changes:

REM @echo off - Echo should be on when you are debugging or you're flying blind
The pipe character | is a special character and must be escaped with ^.
```
echo 2) Quit :^|
```
Incorrect quote mark. Needs to be a double quote.
```
if "!c!" == "1" goto attack1 
```

answered Sep 27, 2016 at 23:30

FloatingKiwi

4,5161 gold badge20 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mike Nakis · Accepted Answer · 2016-09-27 23:30:43Z

1

I should warn you that computers are extremely picky when it comes to punctuation.

Things like "!c!" == "1' and "!c!' == "2" will never work.

The | character has a special meaning, so you cannot use it unless you escape it with a ^ or you place it in double quotes together with other stuff.

answered Sep 27, 2016 at 23:30

Mike Nakis

63.1k11 gold badges128 silver badges173 bronze badges

Comments

J03L · Accepted Answer · 2016-10-09 10:16:26Z

1

add

pause >nul

to the end of your batch file. this will make it so the batch file will not close until the user presses a key.

answered Oct 9, 2016 at 10:16

J03L

3243 silver badges17 bronze badges

Collectives™ on Stack Overflow

Can't find syntax error in batch file

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related