Hangfire ASP.NET Core MVC

Question

Having trouble scheduling/enqueuing an MVC action with Hangfire (1.6.5) (Custom IServices works just fine..)

No service for type 'Controllers.MyController' has been registered.

public class MyController : Controller
{
    public IActionResult RenderViewToString() 
    {
        return View();
    }

    public IActionResult Test() 
    {
        //Attempt 1
        Hangfire.BackgroundJob.Enqueue<MyController>(c => c.RenderViewToString());

        //Attempt 2
        Hangfire.BackgroundJob.Enqueue(() => c.RenderViewToString());

        return new EmptyResult();
    }
}

Please note, that it's not called MVC6 anymore. The correct name is "ASP.NET Core MVC" with version 1.0 — Tseng
– Tseng, Commented Oct 17, 2016 at 14:34
There's a much bigger issue here, and that is why you would want to use a controller for this sort of thing? For a start a background task will not return anything. Secondly, you shouldn't be relying on controller/request context to be available to you inside Hangfire tasks either. — DavidG
– DavidG, Commented Oct 17, 2016 at 14:47
@DavidG I know this is not optimal. I am using MVC to render a view to PDF. I need the ControllerContext for that.. Not aware of any other way. — user5378236
– user5378236, Commented Oct 17, 2016 at 14:57
What are you using to generate the PDF? You cannot have access to the controller context, there is none for background tasks. — DavidG
– DavidG, Commented Oct 17, 2016 at 14:58
@DavidG stackoverflow.com/questions/483091/render-a-view-as-a-string — user5378236
– user5378236, Commented Oct 17, 2016 at 15:04

poke · Accepted Answer · 2017-09-19 09:17:41Z

2

By default, controllers aren't being registered with the dependency injection system in ASP.NET Core. You need to explicitly call AddControllersAsService to register them, as explained in this GitHub issue:

Hi,

Maybe I'm wrong but as I tested deeply (and checked Mvc source code), Controllers are not resolved from IServiceProvider, but only constructor arguments of them are resolved from IServiceProvider.

Is that by design? I'm very suprised. Because, I'm using a different DI framework which supports property injection. And I can not use property injection since Controller instances are not requested from IServiceProvider.

Have you added AddControllersAsServices in your Startup (https://github.com/aspnet/Mvc/blob/ab76f743f4ee537939b69bdb9f79bfca35398545/test/WebSites/ControllersFromServicesWebSite/Startup.cs#L37)

See also this answer to a related question for an example and more details.

edited Sep 19, 2017 at 9:17

poke

392k80 gold badges596 silver badges632 bronze badges

answered Oct 17, 2016 at 14:33

Tseng

64.5k18 gold badges200 silver badges215 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user5378236 Over a year ago

Thank you! That takes me one step further. Now the controllers dependencies does not seem to get activated.. A alot of "Object reference not set to an instance of an object" Any ideas?

user5378236 Over a year ago

My bad. HttpContext does not get activated. For obvious reasons.. Have to work around that.

Collectives™ on Stack Overflow

Hangfire ASP.NET Core MVC

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related